src/compiler/register-allocator.cc - Issue 893533003: Revert "Make GCC happy again." and "Initial switch to Chromium-style CHECK_* and DCHECK_* macros.".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/register-allocator.cc

Issue 893533003: Revert "Make GCC happy again." and "Initial switch to Chromium-style CHECK_* and DCHECK_* macros.". (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler/register-allocator.cc

diff --git a/src/compiler/register-allocator.cc b/src/compiler/register-allocator.cc

index 4e5e53b2e6da1d5eba133550d83a1bdb8d803518..e0487fa8e3b1693e2ca5ea201b9f72635fb639cf 100644

--- a/src/compiler/register-allocator.cc

+++ b/src/compiler/register-allocator.cc

@@ -183,7 +183,7 @@ void LiveRange::SetSpillOperand(InstructionOperand* operand) {

void LiveRange::SetSpillRange(SpillRange* spill_range) {

DCHECK(HasNoSpillType() || HasSpillRange());

- DCHECK(spill_range);

+ DCHECK_NE(spill_range, nullptr);

spill_type_ = SpillType::kSpillRange;

spill_range_ = spill_range;

}

« no previous file with comments | « src/compiler/pipeline.cc ('k') | src/compiler/register-allocator-verifier.cc » ('j') | no next file with comments »