Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Side by Side Diff: src/arm/code-stubs-arm.cc

Issue 893533003: Revert "Make GCC happy again." and "Initial switch to Chromium-style CHECK_* and DCHECK_* macros.". (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/api.cc ('k') | src/arm/full-codegen-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM 7 #if V8_TARGET_ARCH_ARM
8 8
9 #include "src/base/bits.h" 9 #include "src/base/bits.h"
10 #include "src/bootstrapper.h" 10 #include "src/bootstrapper.h"
(...skipping 543 matching lines...) Expand 10 before | Expand all | Expand 10 after
554 // NOTICE! This code is only reached after a smi-fast-case check, so 554 // NOTICE! This code is only reached after a smi-fast-case check, so
555 // it is certain that at least one operand isn't a smi. 555 // it is certain that at least one operand isn't a smi.
556 556
557 // Handle the case where the objects are identical. Either returns the answer 557 // Handle the case where the objects are identical. Either returns the answer
558 // or goes to slow. Only falls through if the objects were not identical. 558 // or goes to slow. Only falls through if the objects were not identical.
559 EmitIdenticalObjectComparison(masm, &slow, cc); 559 EmitIdenticalObjectComparison(masm, &slow, cc);
560 560
561 // If either is a Smi (we know that not both are), then they can only 561 // If either is a Smi (we know that not both are), then they can only
562 // be strictly equal if the other is a HeapNumber. 562 // be strictly equal if the other is a HeapNumber.
563 STATIC_ASSERT(kSmiTag == 0); 563 STATIC_ASSERT(kSmiTag == 0);
564 DCHECK_EQ(static_cast<Smi*>(0), Smi::FromInt(0)); 564 DCHECK_EQ(0, Smi::FromInt(0));
565 __ and_(r2, lhs, Operand(rhs)); 565 __ and_(r2, lhs, Operand(rhs));
566 __ JumpIfNotSmi(r2, &not_smis); 566 __ JumpIfNotSmi(r2, &not_smis);
567 // One operand is a smi. EmitSmiNonsmiComparison generates code that can: 567 // One operand is a smi. EmitSmiNonsmiComparison generates code that can:
568 // 1) Return the answer. 568 // 1) Return the answer.
569 // 2) Go to slow. 569 // 2) Go to slow.
570 // 3) Fall through to both_loaded_as_doubles. 570 // 3) Fall through to both_loaded_as_doubles.
571 // 4) Jump to lhs_not_nan. 571 // 4) Jump to lhs_not_nan.
572 // In cases 3 and 4 we have found out we were dealing with a number-number 572 // In cases 3 and 4 we have found out we were dealing with a number-number
573 // comparison. If VFP3 is supported the double values of the numbers have 573 // comparison. If VFP3 is supported the double values of the numbers have
574 // been loaded into d7 and d6. Otherwise, the double values have been loaded 574 // been loaded into d7 and d6. Otherwise, the double values have been loaded
(...skipping 4368 matching lines...) Expand 10 before | Expand all | Expand 10 after
4943 kStackUnwindSpace, NULL, 4943 kStackUnwindSpace, NULL,
4944 MemOperand(fp, 6 * kPointerSize), NULL); 4944 MemOperand(fp, 6 * kPointerSize), NULL);
4945 } 4945 }
4946 4946
4947 4947
4948 #undef __ 4948 #undef __
4949 4949
4950 } } // namespace v8::internal 4950 } } // namespace v8::internal
4951 4951
4952 #endif // V8_TARGET_ARCH_ARM 4952 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/api.cc ('k') | src/arm/full-codegen-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698