Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Side by Side Diff: test/cctest/test-flags.cc

Issue 893533003: Revert "Make GCC happy again." and "Initial switch to Chromium-style CHECK_* and DCHECK_* macros.". (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « test/cctest/test-fixed-dtoa.cc ('k') | test/cctest/test-func-name-inference.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 237 matching lines...) Expand 10 before | Expand all | Expand 10 after
248 248
249 TEST(FlagsRemoveIncomplete) { 249 TEST(FlagsRemoveIncomplete) {
250 // Test that processed command line arguments are removed, even 250 // Test that processed command line arguments are removed, even
251 // if the list of arguments ends unexpectedly. 251 // if the list of arguments ends unexpectedly.
252 SetFlagsToDefault(); 252 SetFlagsToDefault();
253 int argc = 3; 253 int argc = 3;
254 const char* argv[] = { "", "--crankshaft", "--expose-debug-as" }; 254 const char* argv[] = { "", "--crankshaft", "--expose-debug-as" };
255 CHECK_EQ(2, FlagList::SetFlagsFromCommandLine(&argc, 255 CHECK_EQ(2, FlagList::SetFlagsFromCommandLine(&argc,
256 const_cast<char **>(argv), 256 const_cast<char **>(argv),
257 true)); 257 true));
258 CHECK(argv[1]); 258 CHECK_NE(NULL, argv[1]);
259 CHECK_EQ(argc, 2); 259 CHECK_EQ(argc, 2);
260 } 260 }
OLDNEW
« no previous file with comments | « test/cctest/test-fixed-dtoa.cc ('k') | test/cctest/test-func-name-inference.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698