Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Side by Side Diff: test/cctest/compiler/test-js-typed-lowering.cc

Issue 893533003: Revert "Make GCC happy again." and "Initial switch to Chromium-style CHECK_* and DCHECK_* macros.". (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « test/cctest/compiler/test-js-constant-cache.cc ('k') | test/cctest/compiler/test-linkage.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/graph-inl.h" 5 #include "src/compiler/graph-inl.h"
6 #include "src/compiler/js-graph.h" 6 #include "src/compiler/js-graph.h"
7 #include "src/compiler/js-typed-lowering.h" 7 #include "src/compiler/js-typed-lowering.h"
8 #include "src/compiler/machine-operator.h" 8 #include "src/compiler/machine-operator.h"
9 #include "src/compiler/node-properties.h" 9 #include "src/compiler/node-properties.h"
10 #include "src/compiler/opcodes.h" 10 #include "src/compiler/opcodes.h"
(...skipping 779 matching lines...) Expand 10 before | Expand all | Expand 10 after
790 790
791 if (effect_use != NULL) { 791 if (effect_use != NULL) {
792 R.CheckEffectInput(R.start(), effect_use); 792 R.CheckEffectInput(R.start(), effect_use);
793 // Check that value uses of ToNumber() do not go to start(). 793 // Check that value uses of ToNumber() do not go to start().
794 for (int i = 0; i < effect_use->op()->ValueInputCount(); i++) { 794 for (int i = 0; i < effect_use->op()->ValueInputCount(); i++) {
795 CHECK_NE(R.start(), effect_use->InputAt(i)); 795 CHECK_NE(R.start(), effect_use->InputAt(i));
796 } 796 }
797 } 797 }
798 } 798 }
799 799
800 CHECK(!effect_use); // should have done all cases above. 800 CHECK_EQ(NULL, effect_use); // should have done all cases above.
801 } 801 }
802 802
803 803
804 // Helper class for testing the reduction of a single binop. 804 // Helper class for testing the reduction of a single binop.
805 class BinopEffectsTester { 805 class BinopEffectsTester {
806 public: 806 public:
807 explicit BinopEffectsTester(const Operator* op, Type* t0, Type* t1) 807 explicit BinopEffectsTester(const Operator* op, Type* t0, Type* t1)
808 : R(), 808 : R(),
809 p0(R.Parameter(t0, 0)), 809 p0(R.Parameter(t0, 0)),
810 p1(R.Parameter(t1, 1)), 810 p1(R.Parameter(t1, 1)),
(...skipping 466 matching lines...) Expand 10 before | Expand all | Expand 10 after
1277 CHECK_EQ(p1, r->InputAt(0)); 1277 CHECK_EQ(p1, r->InputAt(0));
1278 CHECK_EQ(p0, r->InputAt(1)); 1278 CHECK_EQ(p0, r->InputAt(1));
1279 } else { 1279 } else {
1280 CHECK_EQ(p0, r->InputAt(0)); 1280 CHECK_EQ(p0, r->InputAt(0));
1281 CHECK_EQ(p1, r->InputAt(1)); 1281 CHECK_EQ(p1, r->InputAt(1));
1282 } 1282 }
1283 } 1283 }
1284 } 1284 }
1285 } 1285 }
1286 } 1286 }
OLDNEW
« no previous file with comments | « test/cctest/compiler/test-js-constant-cache.cc ('k') | test/cctest/compiler/test-linkage.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698