Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: test/cctest/test-version.cc

Issue 893533003: Revert "Make GCC happy again." and "Initial switch to Chromium-style CHECK_* and DCHECK_* macros.". (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/test-symbols.cc ('k') | test/cctest/trace-extension.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-version.cc
diff --git a/test/cctest/test-version.cc b/test/cctest/test-version.cc
index 7de4467d6b3f90b31a0bb35d8c7a268add935dc6..231451d11ae9daa5551306c2c6d7d1859e40f107 100644
--- a/test/cctest/test-version.cc
+++ b/test/cctest/test-version.cc
@@ -59,17 +59,17 @@ static void CheckVersion(int major, int minor, int build,
// Test version without specific SONAME.
SetVersion(major, minor, build, patch, candidate, "");
Version::GetString(version_str);
- CHECK_EQ(0, strcmp(expected_version_string, version_str.start()));
+ CHECK_EQ(expected_version_string, version_str.start());
Version::GetSONAME(soname_str);
- CHECK_EQ(0, strcmp(expected_generic_soname, soname_str.start()));
+ CHECK_EQ(expected_generic_soname, soname_str.start());
// Test version with specific SONAME.
const char* soname = "libv8.so.1";
SetVersion(major, minor, build, patch, candidate, soname);
Version::GetString(version_str);
- CHECK_EQ(0, strcmp(expected_version_string, version_str.start()));
+ CHECK_EQ(expected_version_string, version_str.start());
Version::GetSONAME(soname_str);
- CHECK_EQ(0, strcmp(soname, soname_str.start()));
+ CHECK_EQ(soname, soname_str.start());
}
« no previous file with comments | « test/cctest/test-symbols.cc ('k') | test/cctest/trace-extension.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698