test/cctest/compiler/value-helper.h - Issue 893533003: Revert "Make GCC happy again." and "Initial switch to Chromium-style CHECK_* and DCHECK_* macros.".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/compiler/value-helper.h

Issue 893533003: Revert "Make GCC happy again." and "Initial switch to Chromium-style CHECK_* and DCHECK_* macros.". (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/cctest/compiler/value-helper.h

diff --git a/test/cctest/compiler/value-helper.h b/test/cctest/compiler/value-helper.h

index 208fa437c25fe29c4c0145b1532797c65491ea78..caf1daf3a7dd75fd84250b111b2b0c0cff3d3646 100644

--- a/test/cctest/compiler/value-helper.h

+++ b/test/cctest/compiler/value-helper.h

@@ -44,7 +44,7 @@ class ValueHelper {

void CheckUint32Constant(int32_t expected, Node* node) {

CHECK_EQ(IrOpcode::kInt32Constant, node->opcode());

- CHECK_EQ(expected, OpParameter<int32_t>(node));

+ CHECK_EQ(expected, OpParameter<uint32_t>(node));

}

void CheckHeapConstant(Object* expected, Node* node) {

« no previous file with comments | « test/cctest/compiler/test-run-machops.cc ('k') | test/cctest/test-accessors.cc » ('j') | no next file with comments »