Revert "Make GCC happy again." and "Initial switch to Chromium-style CHECK_* and DCHECK_* macros.".

test/cctest/test-dtoa.cc

 // Copyright 2010 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 46 matching lines @@
 
 
 TEST(DtoaVariousDoubles) {
   char buffer_container[kBufferSize];
   Vector<char> buffer(buffer_container, kBufferSize);
   int length;
   int point;
   int sign;
 
   DoubleToAscii(0.0, DTOA_SHORTEST, 0, buffer, &sign, &length, &point);
-  CHECK_EQ(0, strcmp("0", buffer.start()));
+  CHECK_EQ("0", buffer.start());
   CHECK_EQ(1, point);
 
   DoubleToAscii(0.0, DTOA_FIXED, 2, buffer, &sign, &length, &point);
   CHECK_EQ(1, length);
-  CHECK_EQ(0, strcmp("0", buffer.start()));
+  CHECK_EQ("0", buffer.start());
   CHECK_EQ(1, point);
 
   DoubleToAscii(0.0, DTOA_PRECISION, 3, buffer, &sign, &length, &point);
   CHECK_EQ(1, length);
-  CHECK_EQ(0, strcmp("0", buffer.start()));
+  CHECK_EQ("0", buffer.start());
   CHECK_EQ(1, point);
 
   DoubleToAscii(1.0, DTOA_SHORTEST, 0, buffer, &sign, &length, &point);
-  CHECK_EQ(0, strcmp("1", buffer.start()));
+  CHECK_EQ("1", buffer.start());
   CHECK_EQ(1, point);
 
   DoubleToAscii(1.0, DTOA_FIXED, 3, buffer, &sign, &length, &point);
   CHECK_GE(3, length - point);
   TrimRepresentation(buffer);
-  CHECK_EQ(0, strcmp("1", buffer.start()));
+  CHECK_EQ("1", buffer.start());
   CHECK_EQ(1, point);
 
   DoubleToAscii(1.0, DTOA_PRECISION, 3, buffer, &sign, &length, &point);
   CHECK_GE(3, length);
   TrimRepresentation(buffer);
-  CHECK_EQ(0, strcmp("1", buffer.start()));
+  CHECK_EQ("1", buffer.start());
   CHECK_EQ(1, point);
 
   DoubleToAscii(1.5, DTOA_SHORTEST, 0, buffer, &sign, &length, &point);
-  CHECK_EQ(0, strcmp("15", buffer.start()));
+  CHECK_EQ("15", buffer.start());
   CHECK_EQ(1, point);
 
   DoubleToAscii(1.5, DTOA_FIXED, 10, buffer, &sign, &length, &point);
   CHECK_GE(10, length - point);
   TrimRepresentation(buffer);
-  CHECK_EQ(0, strcmp("15", buffer.start()));
+  CHECK_EQ("15", buffer.start());
   CHECK_EQ(1, point);
 
   DoubleToAscii(1.5, DTOA_PRECISION, 10, buffer, &sign, &length, &point);
   CHECK_GE(10, length);
   TrimRepresentation(buffer);
-  CHECK_EQ(0, strcmp("15", buffer.start()));
+  CHECK_EQ("15", buffer.start());
   CHECK_EQ(1, point);
 
   double min_double = 5e-324;
   DoubleToAscii(min_double, DTOA_SHORTEST, 0, buffer, &sign, &length, &point);
-  CHECK_EQ(0, strcmp("5", buffer.start()));
+  CHECK_EQ("5", buffer.start());
   CHECK_EQ(-323, point);
 
   DoubleToAscii(min_double, DTOA_FIXED, 5, buffer, &sign, &length, &point);
   CHECK_GE(5, length - point);
   TrimRepresentation(buffer);
-  CHECK_EQ(0, strcmp("", buffer.start()));
+  CHECK_EQ("", buffer.start());
   CHECK_GE(-5, point);
 
   DoubleToAscii(min_double, DTOA_PRECISION, 5, buffer, &sign, &length, &point);
   CHECK_GE(5, length);
   TrimRepresentation(buffer);
-  CHECK_EQ(0, strcmp("49407", buffer.start()));
+  CHECK_EQ("49407", buffer.start());
   CHECK_EQ(-323, point);
 
   double max_double = 1.7976931348623157e308;
   DoubleToAscii(max_double, DTOA_SHORTEST, 0, buffer, &sign, &length, &point);
-  CHECK_EQ(0, strcmp("17976931348623157", buffer.start()));
+  CHECK_EQ("17976931348623157", buffer.start());
   CHECK_EQ(309, point);
 
   DoubleToAscii(max_double, DTOA_PRECISION, 7, buffer, &sign, &length, &point);
   CHECK_GE(7, length);
   TrimRepresentation(buffer);
-  CHECK_EQ(0, strcmp("1797693", buffer.start()));
+  CHECK_EQ("1797693", buffer.start());
   CHECK_EQ(309, point);
 
   DoubleToAscii(4294967272.0, DTOA_SHORTEST, 0, buffer, &sign, &length, &point);
-  CHECK_EQ(0, strcmp("4294967272", buffer.start()));
+  CHECK_EQ("4294967272", buffer.start());
   CHECK_EQ(10, point);
 
   DoubleToAscii(4294967272.0, DTOA_FIXED, 5, buffer, &sign, &length, &point);
   CHECK_GE(5, length - point);
   TrimRepresentation(buffer);
-  CHECK_EQ(0, strcmp("4294967272", buffer.start()));
+  CHECK_EQ("4294967272", buffer.start());
   CHECK_EQ(10, point);
 
 
   DoubleToAscii(4294967272.0, DTOA_PRECISION, 14,
                 buffer, &sign, &length, &point);
   CHECK_GE(14, length);
   TrimRepresentation(buffer);
-  CHECK_EQ(0, strcmp("4294967272", buffer.start()));
+  CHECK_EQ("4294967272", buffer.start());
   CHECK_EQ(10, point);
 
   DoubleToAscii(4.1855804968213567e298, DTOA_SHORTEST, 0,
                 buffer, &sign, &length, &point);
-  CHECK_EQ(0, strcmp("4185580496821357", buffer.start()));
+  CHECK_EQ("4185580496821357", buffer.start());
   CHECK_EQ(299, point);
 
   DoubleToAscii(4.1855804968213567e298, DTOA_PRECISION, 20,
                 buffer, &sign, &length, &point);
   CHECK_GE(20, length);
   TrimRepresentation(buffer);
-  CHECK_EQ(0, strcmp("41855804968213567225", buffer.start()));
+  CHECK_EQ("41855804968213567225", buffer.start());
   CHECK_EQ(299, point);
 
   DoubleToAscii(5.5626846462680035e-309, DTOA_SHORTEST, 0,
                 buffer, &sign, &length, &point);
-  CHECK_EQ(0, strcmp("5562684646268003", buffer.start()));
+  CHECK_EQ("5562684646268003", buffer.start());
   CHECK_EQ(-308, point);
 
   DoubleToAscii(5.5626846462680035e-309, DTOA_PRECISION, 1,
                 buffer, &sign, &length, &point);
   CHECK_GE(1, length);
   TrimRepresentation(buffer);
-  CHECK_EQ(0, strcmp("6", buffer.start()));
+  CHECK_EQ("6", buffer.start());
   CHECK_EQ(-308, point);
 
   DoubleToAscii(-2147483648.0, DTOA_SHORTEST, 0,
                 buffer, &sign, &length, &point);
   CHECK_EQ(1, sign);
-  CHECK_EQ(0, strcmp("2147483648", buffer.start()));
+  CHECK_EQ("2147483648", buffer.start());
   CHECK_EQ(10, point);
 
 
   DoubleToAscii(-2147483648.0, DTOA_FIXED, 2, buffer, &sign, &length, &point);
   CHECK_GE(2, length - point);
   TrimRepresentation(buffer);
   CHECK_EQ(1, sign);
-  CHECK_EQ(0, strcmp("2147483648", buffer.start()));
+  CHECK_EQ("2147483648", buffer.start());
   CHECK_EQ(10, point);
 
   DoubleToAscii(-2147483648.0, DTOA_PRECISION, 5,
                 buffer, &sign, &length, &point);
   CHECK_GE(5, length);
   TrimRepresentation(buffer);
   CHECK_EQ(1, sign);
-  CHECK_EQ(0, strcmp("21475", buffer.start()));
+  CHECK_EQ("21475", buffer.start());
   CHECK_EQ(10, point);
 
   DoubleToAscii(-3.5844466002796428e+298, DTOA_SHORTEST, 0,
                 buffer, &sign, &length, &point);
   CHECK_EQ(1, sign);
-  CHECK_EQ(0, strcmp("35844466002796428", buffer.start()));
+  CHECK_EQ("35844466002796428", buffer.start());
   CHECK_EQ(299, point);
 
   DoubleToAscii(-3.5844466002796428e+298, DTOA_PRECISION, 10,
                 buffer, &sign, &length, &point);
   CHECK_EQ(1, sign);
   CHECK_GE(10, length);
   TrimRepresentation(buffer);
-  CHECK_EQ(0, strcmp("35844466", buffer.start()));
+  CHECK_EQ("35844466", buffer.start());
   CHECK_EQ(299, point);
 
   uint64_t smallest_normal64 = V8_2PART_UINT64_C(0x00100000, 00000000);
   double v = Double(smallest_normal64).value();
   DoubleToAscii(v, DTOA_SHORTEST, 0, buffer, &sign, &length, &point);
-  CHECK_EQ(0, strcmp("22250738585072014", buffer.start()));
+  CHECK_EQ("22250738585072014", buffer.start());
   CHECK_EQ(-307, point);
 
   DoubleToAscii(v, DTOA_PRECISION, 20, buffer, &sign, &length, &point);
   CHECK_GE(20, length);
   TrimRepresentation(buffer);
-  CHECK_EQ(0, strcmp("22250738585072013831", buffer.start()));
+  CHECK_EQ("22250738585072013831", buffer.start());
   CHECK_EQ(-307, point);
 
   uint64_t largest_denormal64 = V8_2PART_UINT64_C(0x000FFFFF, FFFFFFFF);
   v = Double(largest_denormal64).value();
   DoubleToAscii(v, DTOA_SHORTEST, 0, buffer, &sign, &length, &point);
-  CHECK_EQ(0, strcmp("2225073858507201", buffer.start()));
+  CHECK_EQ("2225073858507201", buffer.start());
   CHECK_EQ(-307, point);
 
   DoubleToAscii(v, DTOA_PRECISION, 20, buffer, &sign, &length, &point);
   CHECK_GE(20, length);
   TrimRepresentation(buffer);
-  CHECK_EQ(0, strcmp("2225073858507200889", buffer.start()));
+  CHECK_EQ("2225073858507200889", buffer.start());
   CHECK_EQ(-307, point);
 
   DoubleToAscii(4128420500802942e-24, DTOA_SHORTEST, 0,
                 buffer, &sign, &length, &point);
   CHECK_EQ(0, sign);
-  CHECK_EQ(0, strcmp("4128420500802942", buffer.start()));
+  CHECK_EQ("4128420500802942", buffer.start());
   CHECK_EQ(-8, point);
 
   v = -3.9292015898194142585311918e-10;
   DoubleToAscii(v, DTOA_SHORTEST, 0, buffer, &sign, &length, &point);
-  CHECK_EQ(0, strcmp("39292015898194143", buffer.start()));
+  CHECK_EQ("39292015898194143", buffer.start());
 
   v = 4194304.0;
   DoubleToAscii(v, DTOA_FIXED, 5, buffer, &sign, &length, &point);
   CHECK_GE(5, length - point);
   TrimRepresentation(buffer);
-  CHECK_EQ(0, strcmp("4194304", buffer.start()));
+  CHECK_EQ("4194304", buffer.start());
 
   v = 3.3161339052167390562200598e-237;
   DoubleToAscii(v, DTOA_PRECISION, 19, buffer, &sign, &length, &point);
   CHECK_GE(19, length);
   TrimRepresentation(buffer);
-  CHECK_EQ(0, strcmp("3316133905216739056", buffer.start()));
+  CHECK_EQ("3316133905216739056", buffer.start());
   CHECK_EQ(-236, point);
 }
 
 
 TEST(DtoaGayShortest) {
   char buffer_container[kBufferSize];
   Vector<char> buffer(buffer_container, kBufferSize);
   int sign;
   int length;
   int point;
 
   Vector<const PrecomputedShortest> precomputed =
       PrecomputedShortestRepresentations();
   for (int i = 0; i < precomputed.length(); ++i) {
     const PrecomputedShortest current_test = precomputed[i];
     double v = current_test.v;
     DoubleToAscii(v, DTOA_SHORTEST, 0, buffer, &sign, &length, &point);
     CHECK_EQ(0, sign);  // All precomputed numbers are positive.
     CHECK_EQ(current_test.decimal_point, point);
-    CHECK_EQ(0, strcmp(current_test.representation, buffer.start()));
+    CHECK_EQ(current_test.representation, buffer.start());
   }
 }
 
 
 TEST(DtoaGayFixed) {
   char buffer_container[kBufferSize];
   Vector<char> buffer(buffer_container, kBufferSize);
   int sign;
   int length;
   int point;
 
   Vector<const PrecomputedFixed> precomputed =
       PrecomputedFixedRepresentations();
   for (int i = 0; i < precomputed.length(); ++i) {
     const PrecomputedFixed current_test = precomputed[i];
     double v = current_test.v;
     int number_digits = current_test.number_digits;
     DoubleToAscii(v, DTOA_FIXED, number_digits, buffer, &sign, &length, &point);
     CHECK_EQ(0, sign);  // All precomputed numbers are positive.
     CHECK_EQ(current_test.decimal_point, point);
     CHECK_GE(number_digits, length - point);
     TrimRepresentation(buffer);
-    CHECK_EQ(0, strcmp(current_test.representation, buffer.start()));
+    CHECK_EQ(current_test.representation, buffer.start());
   }
 }
 
 
 TEST(DtoaGayPrecision) {
   char buffer_container[kBufferSize];
   Vector<char> buffer(buffer_container, kBufferSize);
   int sign;
   int length;
   int point;
 
   Vector<const PrecomputedPrecision> precomputed =
       PrecomputedPrecisionRepresentations();
   for (int i = 0; i < precomputed.length(); ++i) {
     const PrecomputedPrecision current_test = precomputed[i];
     double v = current_test.v;
     int number_digits = current_test.number_digits;
     DoubleToAscii(v, DTOA_PRECISION, number_digits,
                   buffer, &sign, &length, &point);
     CHECK_EQ(0, sign);  // All precomputed numbers are positive.
     CHECK_EQ(current_test.decimal_point, point);
     CHECK_GE(number_digits, length);
     TrimRepresentation(buffer);
-    CHECK_EQ(0, strcmp(current_test.representation, buffer.start()));
+    CHECK_EQ(current_test.representation, buffer.start());
   }
 }