src/perf-jit.cc - Issue 893533003: Revert "Make GCC happy again." and "Initial switch to Chromium-style CHECK_* and DCHECK_* macros.".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/perf-jit.cc

Issue 893533003: Revert "Make GCC happy again." and "Initial switch to Chromium-style CHECK_* and DCHECK_* macros.". (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/perf-jit.cc

diff --git a/src/perf-jit.cc b/src/perf-jit.cc

index 819fe4eef42e04b56b9384759d35e7d700b856a0..3f30e384674fb5d7ee05b5621824290244d62ef3 100644

--- a/src/perf-jit.cc

+++ b/src/perf-jit.cc

@@ -57,7 +57,7 @@ PerfJitLogger::PerfJitLogger() : perf_output_handle_(NULL), code_index_(0) {

CHECK_NE(size, -1);

perf_output_handle_ =

base::OS::FOpen(perf_dump_name.start(), base::OS::LogFileOpenMode);

- CHECK_NOT_NULL(perf_output_handle_);

+ CHECK_NE(perf_output_handle_, NULL);

setvbuf(perf_output_handle_, NULL, _IOFBF, kLogBufferSize);

LogWriteHeader();

« no previous file with comments | « src/optimizing-compiler-thread.cc ('k') | src/ppc/full-codegen-ppc.cc » ('j') | no next file with comments »