src/bootstrapper.cc - Issue 893533003: Revert "Make GCC happy again." and "Initial switch to Chromium-style CHECK_* and DCHECK_* macros.".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/bootstrapper.cc

Issue 893533003: Revert "Make GCC happy again." and "Initial switch to Chromium-style CHECK_* and DCHECK_* macros.". (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/bootstrapper.cc

diff --git a/src/bootstrapper.cc b/src/bootstrapper.cc

index f5baafc42f92bffbbe64d4be4054119742e98026..aef94282cac24c616d7209258742bb9c929cb18a 100644

--- a/src/bootstrapper.cc

+++ b/src/bootstrapper.cc

@@ -1491,7 +1491,7 @@ static Handle<JSObject> ResolveBuiltinIdHolder(Handle<Context> native_context,

.ToHandleChecked());

}

const char* inner = period_pos + 1;

- DCHECK(!strchr(inner, '.'));

+ DCHECK_EQ(NULL, strchr(inner, '.'));

Vector<const char> property(holder_expr,

static_cast<int>(period_pos - holder_expr));

Handle<String> property_string = factory->InternalizeUtf8String(property);

« no previous file with comments | « src/base/platform/time.cc ('k') | src/checks.h » ('j') | no next file with comments »