src/objects-inl.h - Issue 893533003: Revert "Make GCC happy again." and "Initial switch to Chromium-style CHECK_* and DCHECK_* macros.".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects-inl.h

Issue 893533003: Revert "Make GCC happy again." and "Initial switch to Chromium-style CHECK_* and DCHECK_* macros.". (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/objects-inl.h

diff --git a/src/objects-inl.h b/src/objects-inl.h

index b097bb1d2e0cf45958fdae8e7c17e5359852219d..a0e2a38bc092df4249d142bcc225bdc4efa0b755 100644

--- a/src/objects-inl.h

+++ b/src/objects-inl.h

@@ -2951,7 +2951,7 @@ int LinearSearch(T* array, Name* name, int len, int valid_entries,

return T::kNotFound;

} else {

DCHECK(len >= valid_entries);

- DCHECK_NULL(out_insertion_index); // Not supported here.

+ DCHECK_EQ(NULL, out_insertion_index); // Not supported here.

for (int number = 0; number < valid_entries; number++) {

Name* entry = array->GetKey(number);

uint32_t current_hash = entry->Hash();

« no previous file with comments | « src/objects-debug.cc ('k') | src/optimizing-compiler-thread.cc » ('j') | no next file with comments »