src/base/platform/condition-variable.cc - Issue 893533003: Revert "Make GCC happy again." and "Initial switch to Chromium-style CHECK_* and DCHECK_* macros.".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/base/platform/condition-variable.cc

Issue 893533003: Revert "Make GCC happy again." and "Initial switch to Chromium-style CHECK_* and DCHECK_* macros.". (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/base/platform/condition-variable.cc

diff --git a/src/base/platform/condition-variable.cc b/src/base/platform/condition-variable.cc

index b91025a3dbb86b9e242221695a071d1c8fef7c9b..4547b66f7a6b912705d678c693c90be74996c0d8 100644

--- a/src/base/platform/condition-variable.cc

+++ b/src/base/platform/condition-variable.cc

@@ -182,7 +182,7 @@ void ConditionVariable::NativeHandle::Post(Event* event, bool result) {

// Remove the event from the wait list.

for (Event** wep = &waitlist_;; wep = &(*wep)->next_) {

- DCHECK(*wep);

+ DCHECK_NE(NULL, *wep);

if (*wep == event) {

*wep = event->next_;

break;

« no previous file with comments | « src/base/logging.cc ('k') | src/base/platform/time.h » ('j') | no next file with comments »