test/cctest/test-global-object.cc - Issue 893533003: Revert "Make GCC happy again." and "Initial switch to Chromium-style CHECK_* and DCHECK_* macros.".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-global-object.cc

Issue 893533003: Revert "Make GCC happy again." and "Initial switch to Chromium-style CHECK_* and DCHECK_* macros.". (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/cctest/test-global-object.cc

diff --git a/test/cctest/test-global-object.cc b/test/cctest/test-global-object.cc

index b0ed29daf1c1947b1f37c52ae940d086ffd00885..0e2c9408c6222b4a17c4a89a84a5b811c9731f97 100644

--- a/test/cctest/test-global-object.cc

+++ b/test/cctest/test-global-object.cc

@@ -47,5 +47,5 @@ TEST(StrictUndeclaredGlobalVariable) {

script->Run();

CHECK(try_catch.HasCaught());

v8::String::Utf8Value exception(try_catch.Exception());

- CHECK_EQ(0, strcmp("ReferenceError: x is not defined", *exception));

+ CHECK_EQ("ReferenceError: x is not defined", *exception);

}

« no previous file with comments | « test/cctest/test-func-name-inference.cc ('k') | test/cctest/test-hashmap.cc » ('j') | no next file with comments »