Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(652)

Side by Side Diff: test/cctest/trace-extension.cc

Issue 893533003: Revert "Make GCC happy again." and "Initial switch to Chromium-style CHECK_* and DCHECK_* macros.". (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « test/cctest/test-version.cc ('k') | test/unittests/base/logging-unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 112 matching lines...) Expand 10 before | Expand all | Expand 10 after
123 i::Isolate* isolate = reinterpret_cast<i::Isolate*>(args.GetIsolate()); 123 i::Isolate* isolate = reinterpret_cast<i::Isolate*>(args.GetIsolate());
124 i::VMState<EXTERNAL> state(isolate); 124 i::VMState<EXTERNAL> state(isolate);
125 Address address = reinterpret_cast<Address>( 125 Address address = reinterpret_cast<Address>(
126 reinterpret_cast<intptr_t>(&TraceExtension::JSTrace)); 126 reinterpret_cast<intptr_t>(&TraceExtension::JSTrace));
127 i::ExternalCallbackScope call_scope(isolate, address); 127 i::ExternalCallbackScope call_scope(isolate, address);
128 DoTraceHideCEntryFPAddress(GetFP(args)); 128 DoTraceHideCEntryFPAddress(GetFP(args));
129 } 129 }
130 130
131 131
132 Address TraceExtension::GetJsEntrySp() { 132 Address TraceExtension::GetJsEntrySp() {
133 CHECK(CcTest::i_isolate()->thread_local_top()); 133 CHECK_NE(NULL, CcTest::i_isolate()->thread_local_top());
134 return CcTest::i_isolate()->js_entry_sp(); 134 return CcTest::i_isolate()->js_entry_sp();
135 } 135 }
136 136
137 137
138 void TraceExtension::JSEntrySP( 138 void TraceExtension::JSEntrySP(
139 const v8::FunctionCallbackInfo<v8::Value>& args) { 139 const v8::FunctionCallbackInfo<v8::Value>& args) {
140 CHECK(GetJsEntrySp()); 140 CHECK_NE(0, GetJsEntrySp());
141 } 141 }
142 142
143 143
144 void TraceExtension::JSEntrySPLevel2( 144 void TraceExtension::JSEntrySPLevel2(
145 const v8::FunctionCallbackInfo<v8::Value>& args) { 145 const v8::FunctionCallbackInfo<v8::Value>& args) {
146 v8::HandleScope scope(args.GetIsolate()); 146 v8::HandleScope scope(args.GetIsolate());
147 const Address js_entry_sp = GetJsEntrySp(); 147 const Address js_entry_sp = GetJsEntrySp();
148 CHECK(js_entry_sp); 148 CHECK_NE(0, js_entry_sp);
149 CompileRun("js_entry_sp();"); 149 CompileRun("js_entry_sp();");
150 CHECK_EQ(js_entry_sp, GetJsEntrySp()); 150 CHECK_EQ(js_entry_sp, GetJsEntrySp());
151 } 151 }
152 152
153 153
154 } } // namespace v8::internal 154 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « test/cctest/test-version.cc ('k') | test/unittests/base/logging-unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698