test/cctest/test-symbols.cc - Issue 893533003: Revert "Make GCC happy again." and "Initial switch to Chromium-style CHECK_* and DCHECK_* macros.".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-symbols.cc

Issue 893533003: Revert "Make GCC happy again." and "Initial switch to Chromium-style CHECK_* and DCHECK_* macros.". (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/cctest/test-symbols.cc

diff --git a/test/cctest/test-symbols.cc b/test/cctest/test-symbols.cc

index bb2d117b25d438fd67fc64ebb19f498ddc8b5670..066c99703763dd2cc94e6dd6d5b00799350e49f6 100644

--- a/test/cctest/test-symbols.cc

+++ b/test/cctest/test-symbols.cc

@@ -28,7 +28,7 @@ TEST(Create) {

CHECK(symbols[i]->IsName());

CHECK(symbols[i]->IsSymbol());

CHECK(symbols[i]->HasHashCode());

- CHECK_GT(symbols[i]->Hash(), 0u);

+ CHECK_GT(symbols[i]->Hash(), 0);

os << Brief(*symbols[i]) << "\n";

#if OBJECT_PRINT

symbols[i]->Print(os);

« no previous file with comments | « test/cctest/test-strings.cc ('k') | test/cctest/test-version.cc » ('j') | no next file with comments »