tools/gn: Pass clang-modernize -use-nullptr over it.

tools/gn: convert NULL to nullptr all over it.

nullptr is one of the C++11 allowed features. See https://chromium-cpp.appspot.com/ and https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/4mijeJHzxLg.

This patch was generated with the following command lines:

$ ninja -C out/Debug -t compdb cxx > out/Debug/compile_commands.json
$ cd out/Debug
$ find ../../tools/gn -name '*.cc'  | xargs -n 16 -P 32 \
~/src/repos/llvm/build/bin/clang-modernize -use-nullptr -p . -include \
tools/gn -format -style=Chromium
$ ninja gn gn_unittests

BUG=None
TEST=compiles + gn_unittests
R=brettw@chromium.org

Committed: https://crrev.com/9b636af5b67940f73aa43180b265d41ca6545167
Cr-Commit-Position: refs/heads/master@{#309505}

[tfarina, 2014-12-21 02:18:34]

Brett, is this OK?

[brettw, 2014-12-21 17:00:41]

Can you change the commit message a bit to say this changes NULL -> nullptr in
tools/gn. Then secondarily talk about how you used clang to do this (the point
is the change itself, not the fact that you ran clang-modernize).

LGTM with the following:

https://codereview.chromium.org/798333005/diff/1/tools/gn/commands.cc
File tools/gn/commands.cc (right):

https://codereview.chromium.org/798333005/diff/1/tools/gn/commands.cc#newcode17
tools/gn/commands.cc:17: : help_short(nullptr), help(nullptr), runner(nullptr) {
I liked these on separate lines.

https://codereview.chromium.org/798333005/diff/1/tools/gn/location.cc
File tools/gn/location.cc (right):

https://codereview.chromium.org/798333005/diff/1/tools/gn/location.cc#newcode11
tools/gn/location.cc:11: Location::Location() : file_(nullptr),
line_number_(-1), char_offset_(-1) {
Ditto

https://codereview.chromium.org/798333005/diff/1/tools/gn/parse_tree.cc
File tools/gn/parse_tree.cc (left):

https://codereview.chromium.org/798333005/diff/1/tools/gn/parse_tree.cc#oldco...
tools/gn/parse_tree.cc:41: const AccessorNode* ParseNode::AsAccessor() const {
return NULL; }
I like this old formatting better.

https://codereview.chromium.org/798333005/diff/1/tools/gn/value.cc
File tools/gn/value.cc (right):

https://codereview.chromium.org/798333005/diff/1/tools/gn/value.cc#newcode12
tools/gn/value.cc:12: : type_(NONE), boolean_value_(false), int_value_(0),
origin_(nullptr) {
Ditto

[tfarina, 2014-12-23 00:06:44]

CL description updated.

Pushing to CQ.

https://codereview.chromium.org/798333005/diff/1/tools/gn/commands.cc
File tools/gn/commands.cc (right):

https://codereview.chromium.org/798333005/diff/1/tools/gn/commands.cc#newcode17
tools/gn/commands.cc:17: : help_short(nullptr), help(nullptr), runner(nullptr) {
On 2014/12/21 17:00:41, brettw wrote:
> I liked these on separate lines.

Me too. :)

Done.

https://codereview.chromium.org/798333005/diff/1/tools/gn/location.cc
File tools/gn/location.cc (right):

https://codereview.chromium.org/798333005/diff/1/tools/gn/location.cc#newcode11
tools/gn/location.cc:11: Location::Location() : file_(nullptr),
line_number_(-1), char_offset_(-1) {
On 2014/12/21 17:00:41, brettw wrote:
> Ditto

Done.

https://codereview.chromium.org/798333005/diff/1/tools/gn/parse_tree.cc
File tools/gn/parse_tree.cc (left):

https://codereview.chromium.org/798333005/diff/1/tools/gn/parse_tree.cc#oldco...
tools/gn/parse_tree.cc:41: const AccessorNode* ParseNode::AsAccessor() const {
return NULL; }
On 2014/12/21 17:00:41, brettw wrote:
> I like this old formatting better.

Done.

https://codereview.chromium.org/798333005/diff/1/tools/gn/value.cc
File tools/gn/value.cc (right):

https://codereview.chromium.org/798333005/diff/1/tools/gn/value.cc#newcode12
tools/gn/value.cc:12: : type_(NONE), boolean_value_(false), int_value_(0),
origin_(nullptr) {
On 2014/12/21 17:00:41, brettw wrote:
> Ditto

Done.

[tfarina, 2014-12-23 00:07:25]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2014-12-23 00:09:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/798333005/20001

[commit-bot: I haz the power, 2014-12-23 00:52:37]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-12-23 00:53:17]

Patchset 2 (id:??) landed as
https://crrev.com/9b636af5b67940f73aa43180b265d41ca6545167
Cr-Commit-Position: refs/heads/master@{#309505}