Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Unified Diff: tools/gn/filesystem_utils_unittest.cc

Issue 798333005: tools/gn: Pass clang-modernize -use-nullptr over it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address Brett's review - revert some clang-format changes Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/filesystem_utils.cc ('k') | tools/gn/function_foreach.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/filesystem_utils_unittest.cc
diff --git a/tools/gn/filesystem_utils_unittest.cc b/tools/gn/filesystem_utils_unittest.cc
index bbf33369507a08810d84346b2e35cf182c1bd4ee..d398366e69c6f8e27536d954d2167ec32ebb0b42 100644
--- a/tools/gn/filesystem_utils_unittest.cc
+++ b/tools/gn/filesystem_utils_unittest.cc
@@ -97,25 +97,25 @@ TEST(FilesystemUtils, EnsureStringIsInOutputDir) {
// Some outside.
Err err;
- EXPECT_FALSE(EnsureStringIsInOutputDir(output_dir, "//foo", NULL, &err));
+ EXPECT_FALSE(EnsureStringIsInOutputDir(output_dir, "//foo", nullptr, &err));
EXPECT_TRUE(err.has_error());
err = Err();
- EXPECT_FALSE(EnsureStringIsInOutputDir(output_dir, "//out/Debugit", NULL,
- &err));
+ EXPECT_FALSE(
+ EnsureStringIsInOutputDir(output_dir, "//out/Debugit", nullptr, &err));
EXPECT_TRUE(err.has_error());
// Some inside.
err = Err();
- EXPECT_TRUE(EnsureStringIsInOutputDir(output_dir, "//out/Debug/", NULL,
- &err));
+ EXPECT_TRUE(
+ EnsureStringIsInOutputDir(output_dir, "//out/Debug/", nullptr, &err));
EXPECT_FALSE(err.has_error());
- EXPECT_TRUE(EnsureStringIsInOutputDir(output_dir, "//out/Debug/foo", NULL,
- &err));
+ EXPECT_TRUE(
+ EnsureStringIsInOutputDir(output_dir, "//out/Debug/foo", nullptr, &err));
EXPECT_FALSE(err.has_error());
// Pattern but no template expansions are allowed.
EXPECT_FALSE(EnsureStringIsInOutputDir(output_dir, "{{source_gen_dir}}",
- NULL, &err));
+ nullptr, &err));
EXPECT_TRUE(err.has_error());
}
« no previous file with comments | « tools/gn/filesystem_utils.cc ('k') | tools/gn/function_foreach.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698