Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: tools/gn/ninja_copy_target_writer.cc

Issue 798333005: tools/gn: Pass clang-modernize -use-nullptr over it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address Brett's review - revert some clang-format changes Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/ninja_build_writer.cc ('k') | tools/gn/operators_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/ninja_copy_target_writer.cc
diff --git a/tools/gn/ninja_copy_target_writer.cc b/tools/gn/ninja_copy_target_writer.cc
index 26455d9852e0ea8efd87de9d49cc6561cc86e294..9cd1b72771d5f29a3f375c9133c0043e48106dac 100644
--- a/tools/gn/ninja_copy_target_writer.cc
+++ b/tools/gn/ninja_copy_target_writer.cc
@@ -25,23 +25,23 @@ NinjaCopyTargetWriter::~NinjaCopyTargetWriter() {
void NinjaCopyTargetWriter::Run() {
const Tool* copy_tool = target_->toolchain()->GetTool(Toolchain::TYPE_COPY);
if (!copy_tool) {
- g_scheduler->FailWithError(Err(NULL,
- "Copy tool not defined",
+ g_scheduler->FailWithError(Err(
+ nullptr, "Copy tool not defined",
"The toolchain " +
- target_->toolchain()->label().GetUserVisibleName(false) +
- "\n used by target " + target_->label().GetUserVisibleName(false) +
- "\n doesn't define a \"copy\" tool."));
+ target_->toolchain()->label().GetUserVisibleName(false) +
+ "\n used by target " + target_->label().GetUserVisibleName(false) +
+ "\n doesn't define a \"copy\" tool."));
return;
}
const Tool* stamp_tool = target_->toolchain()->GetTool(Toolchain::TYPE_STAMP);
if (!stamp_tool) {
- g_scheduler->FailWithError(Err(NULL,
- "Copy tool not defined",
+ g_scheduler->FailWithError(Err(
+ nullptr, "Copy tool not defined",
"The toolchain " +
- target_->toolchain()->label().GetUserVisibleName(false) +
- "\n used by target " + target_->label().GetUserVisibleName(false) +
- "\n doesn't define a \"stamp\" tool."));
+ target_->toolchain()->label().GetUserVisibleName(false) +
+ "\n used by target " + target_->label().GetUserVisibleName(false) +
+ "\n doesn't define a \"stamp\" tool."));
return;
}
« no previous file with comments | « tools/gn/ninja_build_writer.cc ('k') | tools/gn/operators_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698