tools/gn/function_set_default_toolchain.cc - Issue 798333005: tools/gn: Pass clang-modernize -use-nullptr over it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/function_set_default_toolchain.cc

Issue 798333005: tools/gn: Pass clang-modernize -use-nullptr over it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address Brett's review - revert some clang-format changes Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/gn/function_set_default_toolchain.cc

diff --git a/tools/gn/function_set_default_toolchain.cc b/tools/gn/function_set_default_toolchain.cc

index 1eb5ee09b818ffa26334a9cb61b56d7e0dbddecb..cc5929e6686a4d1de95cc2494738d40f6ea8f6f9 100644

--- a/tools/gn/function_set_default_toolchain.cc

+++ b/tools/gn/function_set_default_toolchain.cc

@@ -57,7 +57,7 @@ Value RunSetDefaultToolchain(Scope* scope,

// When the loader is expecting the default toolchain to be set, it will set

// this key on the scope to point to the destination.

Label* default_toolchain_dest = static_cast<Label*>(

- scope->GetProperty(Loader::kDefaultToolchainKey, NULL));

+ scope->GetProperty(Loader::kDefaultToolchainKey, nullptr));

if (!default_toolchain_dest)

return Value();

« no previous file with comments | « tools/gn/function_rebase_path_unittest.cc ('k') | tools/gn/function_toolchain.cc » ('j') | no next file with comments »