Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: tools/gn/visibility_unittest.cc

Issue 798333005: tools/gn: Pass clang-modernize -use-nullptr over it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address Brett's review - revert some clang-format changes Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/value_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/visibility_unittest.cc
diff --git a/tools/gn/visibility_unittest.cc b/tools/gn/visibility_unittest.cc
index 8be2db67facbcc6683806c5f730904e7bf4430a8..e120f74a0404bb9bcf74b05081d6662d005657d1 100644
--- a/tools/gn/visibility_unittest.cc
+++ b/tools/gn/visibility_unittest.cc
@@ -9,10 +9,10 @@
#include "tools/gn/visibility.h"
TEST(Visibility, CanSeeMe) {
- Value list(NULL, Value::LIST);
- list.list_value().push_back(Value(NULL, "//rec/*")); // Recursive.
- list.list_value().push_back(Value(NULL, "//dir:*")); // One dir.
- list.list_value().push_back(Value(NULL, "//my:name")); // Exact match.
+ Value list(nullptr, Value::LIST);
+ list.list_value().push_back(Value(nullptr, "//rec/*")); // Recursive.
+ list.list_value().push_back(Value(nullptr, "//dir:*")); // One dir.
+ list.list_value().push_back(Value(nullptr, "//my:name")); // Exact match.
Err err;
Visibility vis;
@@ -34,8 +34,8 @@ TEST(Visibility, Public) {
Err err;
Visibility vis;
- Value list(NULL, Value::LIST);
- list.list_value().push_back(Value(NULL, "*"));
+ Value list(nullptr, Value::LIST);
+ list.list_value().push_back(Value(nullptr, "*"));
ASSERT_TRUE(vis.Set(SourceDir("//"), list, &err));
EXPECT_TRUE(vis.CanSeeMe(Label(SourceDir("//random/"), "thing")));
@@ -45,7 +45,7 @@ TEST(Visibility, Public) {
TEST(Visibility, Private) {
Err err;
Visibility vis;
- ASSERT_TRUE(vis.Set(SourceDir("//"), Value(NULL, Value::LIST), &err));
+ ASSERT_TRUE(vis.Set(SourceDir("//"), Value(nullptr, Value::LIST), &err));
EXPECT_FALSE(vis.CanSeeMe(Label(SourceDir("//random/"), "thing")));
EXPECT_FALSE(vis.CanSeeMe(Label(SourceDir("//"), "")));
« no previous file with comments | « tools/gn/value_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698