Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2861)

Unified Diff: tools/gn/ninja_build_writer.cc

Issue 798333005: tools/gn: Pass clang-modernize -use-nullptr over it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address Brett's review - revert some clang-format changes Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/ninja_action_target_writer_unittest.cc ('k') | tools/gn/ninja_copy_target_writer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/ninja_build_writer.cc
diff --git a/tools/gn/ninja_build_writer.cc b/tools/gn/ninja_build_writer.cc
index 9a5e2d68ac45bb0be98b9b286a4e1a7d0a607b9a..8953cb31c533c946f6d030ba2c4b92ed595306aa 100644
--- a/tools/gn/ninja_build_writer.cc
+++ b/tools/gn/ninja_build_writer.cc
@@ -64,7 +64,7 @@ std::string GetSelfInvocationCommand(const BuildSettings* build_settings) {
i->first != switches::kRoot &&
i->first != switches::kArgs) {
std::string escaped_value =
- EscapeString(FilePathToUTF8(i->second), escape_shell, NULL);
+ EscapeString(FilePathToUTF8(i->second), escape_shell, nullptr);
cmdline.AppendSwitchASCII(i->first, escaped_value);
}
}
@@ -289,7 +289,7 @@ void NinjaBuildWriter::WritePhonyRule(const Target* target,
ninja_escape.mode = ESCAPE_NINJA;
// Escape for special chars Ninja will handle.
- std::string escaped = EscapeString(phony_name, ninja_escape, NULL);
+ std::string escaped = EscapeString(phony_name, ninja_escape, nullptr);
out_ << "build " << escaped << ": phony ";
path_output_.WriteFile(out_, target_file);
« no previous file with comments | « tools/gn/ninja_action_target_writer_unittest.cc ('k') | tools/gn/ninja_copy_target_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698