tools/gn/builder_unittest.cc - Issue 798333005: tools/gn: Pass clang-modernize -use-nullptr over it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/builder_unittest.cc

Issue 798333005: tools/gn: Pass clang-modernize -use-nullptr over it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address Brett's review - revert some clang-format changes Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/gn/builder_unittest.cc

diff --git a/tools/gn/builder_unittest.cc b/tools/gn/builder_unittest.cc

index 7a2f6501bd4636e9144aac925064267652ed440d..ffd1a9dcf6899eb9744c591f5eb68518ab2db6a9 100644

--- a/tools/gn/builder_unittest.cc

+++ b/tools/gn/builder_unittest.cc

@@ -25,7 +25,7 @@ class MockLoader : public Loader {

void ToolchainLoaded(const Toolchain* toolchain) override {}

Label GetDefaultToolchain() const override { return Label(); }

const Settings* GetToolchainSettings(const Label& label) const override {

- return NULL;

+ return nullptr;

}

bool HasLoadedNone() const {

« no previous file with comments | « tools/gn/builder_record.cc ('k') | tools/gn/command_desc.cc » ('j') | no next file with comments »