Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: tools/gn/substitution_pattern_unittest.cc

Issue 798333005: tools/gn: Pass clang-modernize -use-nullptr over it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address Brett's review - revert some clang-format changes Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/substitution_pattern.cc ('k') | tools/gn/substitution_type.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/substitution_pattern_unittest.cc
diff --git a/tools/gn/substitution_pattern_unittest.cc b/tools/gn/substitution_pattern_unittest.cc
index 7f62a0a4d019a61768549ff752f1d0eba93a69f1..9f606af0e7ba61f666c641f537e4e757d27bb04b 100644
--- a/tools/gn/substitution_pattern_unittest.cc
+++ b/tools/gn/substitution_pattern_unittest.cc
@@ -9,7 +9,7 @@
TEST(SubstitutionPattern, ParseLiteral) {
SubstitutionPattern pattern;
Err err;
- EXPECT_TRUE(pattern.Parse("This is a literal", NULL, &err));
+ EXPECT_TRUE(pattern.Parse("This is a literal", nullptr, &err));
EXPECT_FALSE(err.has_error());
ASSERT_EQ(1u, pattern.ranges().size());
EXPECT_EQ(SUBSTITUTION_LITERAL, pattern.ranges()[0].type);
@@ -20,7 +20,7 @@ TEST(SubstitutionPattern, ParseComplex) {
SubstitutionPattern pattern;
Err err;
EXPECT_TRUE(pattern.Parse(
- "AA{{source}}{{source_name_part}}BB{{source_file_part}}", NULL, &err));
+ "AA{{source}}{{source_name_part}}BB{{source_file_part}}", nullptr, &err));
EXPECT_FALSE(err.has_error());
ASSERT_EQ(5u, pattern.ranges().size());
@@ -36,14 +36,14 @@ TEST(SubstitutionPattern, ParseComplex) {
TEST(SubstitutionPattern, ParseErrors) {
SubstitutionPattern pattern;
Err err;
- EXPECT_FALSE(pattern.Parse("AA{{source", NULL, &err));
+ EXPECT_FALSE(pattern.Parse("AA{{source", nullptr, &err));
EXPECT_TRUE(err.has_error());
err = Err();
- EXPECT_FALSE(pattern.Parse("{{source_of_evil}}", NULL, &err));
+ EXPECT_FALSE(pattern.Parse("{{source_of_evil}}", nullptr, &err));
EXPECT_TRUE(err.has_error());
err = Err();
- EXPECT_FALSE(pattern.Parse("{{source{{source}}", NULL, &err));
+ EXPECT_FALSE(pattern.Parse("{{source{{source}}", nullptr, &err));
EXPECT_TRUE(err.has_error());
}
« no previous file with comments | « tools/gn/substitution_pattern.cc ('k') | tools/gn/substitution_type.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698