tools/gn/label_pattern_unittest.cc - Issue 798333005: tools/gn: Pass clang-modernize -use-nullptr over it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/label_pattern_unittest.cc

Issue 798333005: tools/gn: Pass clang-modernize -use-nullptr over it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address Brett's review - revert some clang-format changes Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/gn/label_pattern_unittest.cc

diff --git a/tools/gn/label_pattern_unittest.cc b/tools/gn/label_pattern_unittest.cc

index 21d6a9b12149f39cea41864b06e8ec1f697f1b74..9cd5de01f5d77f1e169751868ff5ce7f31d41792 100644

--- a/tools/gn/label_pattern_unittest.cc

+++ b/tools/gn/label_pattern_unittest.cc

@@ -61,7 +61,7 @@ TEST(LabelPattern, PatternParse) {

const PatternCase& cur = cases[i];

Err err;

LabelPattern result =

- LabelPattern::GetPattern(current_dir, Value(NULL, cur.input), &err);

+ LabelPattern::GetPattern(current_dir, Value(nullptr, cur.input), &err);

EXPECT_EQ(cur.success, !err.has_error()) << i << " " << cur.input;

EXPECT_EQ(cur.type, result.type()) << i << " " << cur.input;

« no previous file with comments | « tools/gn/label.cc ('k') | tools/gn/label_unittest.cc » ('j') | no next file with comments »