tools/gn/label_unittest.cc - Issue 798333005: tools/gn: Pass clang-modernize -use-nullptr over it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/label_unittest.cc

Issue 798333005: tools/gn: Pass clang-modernize -use-nullptr over it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address Brett's review - revert some clang-format changes Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/gn/label_unittest.cc

diff --git a/tools/gn/label_unittest.cc b/tools/gn/label_unittest.cc

index 3ffa3f4da221d09a74583754138720a202949fa5..eb1e16c21cc78709ce58dee3533d1c05e1d0732b 100644

--- a/tools/gn/label_unittest.cc

+++ b/tools/gn/label_unittest.cc

@@ -68,7 +68,7 @@ TEST(Label, Resolve) {

std::string location, name;

Err err;

- Value v(NULL, Value::STRING);

+ Value v(nullptr, Value::STRING);

v.string_value() = cur.str;

Label result =

Label::Resolve(SourceDir(cur.cur_dir), default_toolchain, v, &err);

« no previous file with comments | « tools/gn/label_pattern_unittest.cc ('k') | tools/gn/loader.cc » ('j') | no next file with comments »