Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(843)

Unified Diff: tools/gn/function_process_file_template_unittest.cc

Issue 798333005: tools/gn: Pass clang-modernize -use-nullptr over it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address Brett's review - revert some clang-format changes Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/function_get_target_outputs_unittest.cc ('k') | tools/gn/function_rebase_path_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/function_process_file_template_unittest.cc
diff --git a/tools/gn/function_process_file_template_unittest.cc b/tools/gn/function_process_file_template_unittest.cc
index 6cefd8e1a9159960e0357983f5f9a6171fd24cf5..a455222a5494c000be9e12a81085d2a3f32e24b6 100644
--- a/tools/gn/function_process_file_template_unittest.cc
+++ b/tools/gn/function_process_file_template_unittest.cc
@@ -11,16 +11,16 @@ TEST(FunctionProcessFileTemplates, SingleString) {
std::vector<Value> args;
- Value sources(NULL, Value::LIST);
- sources.list_value().push_back(Value(NULL, "//src/foo.txt"));
+ Value sources(nullptr, Value::LIST);
+ sources.list_value().push_back(Value(nullptr, "//src/foo.txt"));
args.push_back(sources);
- Value expansion(NULL, "1234{{source_name_part}}5678");
+ Value expansion(nullptr, "1234{{source_name_part}}5678");
args.push_back(expansion);
Err err;
- Value result = functions::RunProcessFileTemplate(
- setup.scope(), NULL, args, &err);
+ Value result =
+ functions::RunProcessFileTemplate(setup.scope(), nullptr, args, &err);
EXPECT_FALSE(err.has_error());
ASSERT_TRUE(result.type() == Value::LIST);
@@ -34,21 +34,21 @@ TEST(FunctionProcessFileTemplates, MultipleStrings) {
std::vector<Value> args;
- Value sources(NULL, Value::LIST);
- sources.list_value().push_back(Value(NULL, "//src/one.txt"));
- sources.list_value().push_back(Value(NULL, "//src/two.txt"));
+ Value sources(nullptr, Value::LIST);
+ sources.list_value().push_back(Value(nullptr, "//src/one.txt"));
+ sources.list_value().push_back(Value(nullptr, "//src/two.txt"));
args.push_back(sources);
- Value expansions(NULL, Value::LIST);
+ Value expansions(nullptr, Value::LIST);
expansions.list_value().push_back(
- Value(NULL, "1234{{source_name_part}}5678"));
+ Value(nullptr, "1234{{source_name_part}}5678"));
expansions.list_value().push_back(
- Value(NULL, "ABCD{{source_file_part}}EFGH"));
+ Value(nullptr, "ABCD{{source_file_part}}EFGH"));
args.push_back(expansions);
Err err;
- Value result = functions::RunProcessFileTemplate(
- setup.scope(), NULL, args, &err);
+ Value result =
+ functions::RunProcessFileTemplate(setup.scope(), nullptr, args, &err);
EXPECT_FALSE(err.has_error());
ASSERT_TRUE(result.type() == Value::LIST);
« no previous file with comments | « tools/gn/function_get_target_outputs_unittest.cc ('k') | tools/gn/function_rebase_path_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698