tools/gn/scope_unittest.cc - Issue 798333005: tools/gn: Pass clang-modernize -use-nullptr over it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/scope_unittest.cc

Issue 798333005: tools/gn: Pass clang-modernize -use-nullptr over it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address Brett's review - revert some clang-format changes Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/gn/scope_unittest.cc

diff --git a/tools/gn/scope_unittest.cc b/tools/gn/scope_unittest.cc

index 89de4a646226399a5e0c8c7a96b6f083af7340b0..1dd1e65ca148a317b26f1b7a89754e6268d056fb 100644

--- a/tools/gn/scope_unittest.cc

+++ b/tools/gn/scope_unittest.cc

@@ -286,8 +286,8 @@ TEST(Scope, GetMutableValue) {

TEST(Scope, RemovePrivateIdentifiers) {

TestWithScope setup;

- setup.scope()->SetValue("a", Value(NULL, true), NULL);

- setup.scope()->SetValue("_b", Value(NULL, true), NULL);

+ setup.scope()->SetValue("a", Value(nullptr, true), nullptr);

+ setup.scope()->SetValue("_b", Value(nullptr, true), nullptr);

setup.scope()->RemovePrivateIdentifiers();

EXPECT_TRUE(setup.scope()->GetValue("a"));

« no previous file with comments | « tools/gn/scope_per_file_provider.cc ('k') | tools/gn/string_utils_unittest.cc » ('j') | no next file with comments »