tools/gn/ninja_action_target_writer_unittest.cc - Issue 798333005: tools/gn: Pass clang-modernize -use-nullptr over it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/ninja_action_target_writer_unittest.cc

Issue 798333005: tools/gn: Pass clang-modernize -use-nullptr over it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address Brett's review - revert some clang-format changes Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/gn/ninja_action_target_writer_unittest.cc

diff --git a/tools/gn/ninja_action_target_writer_unittest.cc b/tools/gn/ninja_action_target_writer_unittest.cc

index 8c295c938d92063440b1bae058b9666426819d8f..74f155baea35b58ee7ee835f9bd6eb2ba270115c 100644

--- a/tools/gn/ninja_action_target_writer_unittest.cc

+++ b/tools/gn/ninja_action_target_writer_unittest.cc

@@ -294,7 +294,7 @@ TEST(NinjaActionTargetWriter, ForEachWithDepfile) {

SubstitutionPattern depfile;

ASSERT_TRUE(

- depfile.Parse("//out/Debug/gen/{{source_name_part}}.d", NULL, &err));

+ depfile.Parse("//out/Debug/gen/{{source_name_part}}.d", nullptr, &err));

target.action_values().set_depfile(depfile);

target.action_values().args() = SubstitutionList::MakeForTest(

« no previous file with comments | « tools/gn/location.cc ('k') | tools/gn/ninja_build_writer.cc » ('j') | no next file with comments »