tools/gn/test_with_scope.cc - Issue 798333005: tools/gn: Pass clang-modernize -use-nullptr over it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/test_with_scope.cc

Issue 798333005: tools/gn: Pass clang-modernize -use-nullptr over it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address Brett's review - revert some clang-format changes Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/gn/test_with_scope.cc

diff --git a/tools/gn/test_with_scope.cc b/tools/gn/test_with_scope.cc

index 06f4d0476b15868d0417692aa66e0346992bbeea..62849afbf1542bef2e4e55086e7eb7c289a98955 100644

--- a/tools/gn/test_with_scope.cc

+++ b/tools/gn/test_with_scope.cc

@@ -13,7 +13,7 @@ namespace {

void SetCommandForTool(const std::string& cmd, Tool* tool) {

Err err;

SubstitutionPattern command;

- command.Parse(cmd, NULL, &err);

+ command.Parse(cmd, nullptr, &err);

CHECK(!err.has_error())

<< "Couldn't parse \"" << cmd << "\", " << "got " << err.message();

tool->set_command(command);

« no previous file with comments | « tools/gn/template.cc ('k') | tools/gn/trace.cc » ('j') | no next file with comments »