tools/gn/functions_unittest.cc - Issue 798333005: tools/gn: Pass clang-modernize -use-nullptr over it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/functions_unittest.cc

Issue 798333005: tools/gn: Pass clang-modernize -use-nullptr over it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address Brett's review - revert some clang-format changes Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/gn/functions_unittest.cc

diff --git a/tools/gn/functions_unittest.cc b/tools/gn/functions_unittest.cc

index e506b6874b6dbee2c24e96db54fa622d67878d64..82173edac8bc347342d778b7f00f07e7c83bf345 100644

--- a/tools/gn/functions_unittest.cc

+++ b/tools/gn/functions_unittest.cc

@@ -26,9 +26,9 @@ TEST(Functions, Defined) {

// Define a value that's itself a scope value.

const char kDef[] = "def"; // Defined variable name.

- setup.scope()->SetValue(kDef,

- Value(NULL, scoped_ptr<Scope>(new Scope(setup.scope()))),

- NULL);

+ setup.scope()->SetValue(

+ kDef, Value(nullptr, scoped_ptr<Scope>(new Scope(setup.scope()))),

+ nullptr);

// Test the defined identifier.

Token defined_token(Location(), Token::IDENTIFIER, kDef);

« no previous file with comments | « tools/gn/functions.cc ('k') | tools/gn/import_manager.cc » ('j') | no next file with comments »