Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Unified Diff: tools/gn/function_rebase_path_unittest.cc

Issue 798333005: tools/gn: Pass clang-modernize -use-nullptr over it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address Brett's review - revert some clang-format changes Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/function_process_file_template_unittest.cc ('k') | tools/gn/function_set_default_toolchain.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/function_rebase_path_unittest.cc
diff --git a/tools/gn/function_rebase_path_unittest.cc b/tools/gn/function_rebase_path_unittest.cc
index 20b492e99b2031bb919b933a437854c7aa40e3f0..bed5663917b66df3fb6c78e08c6777441f220824 100644
--- a/tools/gn/function_rebase_path_unittest.cc
+++ b/tools/gn/function_rebase_path_unittest.cc
@@ -15,9 +15,9 @@ std::string RebaseOne(Scope* scope,
const char* to_dir,
const char* from_dir) {
std::vector<Value> args;
- args.push_back(Value(NULL, input));
- args.push_back(Value(NULL, to_dir));
- args.push_back(Value(NULL, from_dir));
+ args.push_back(Value(nullptr, input));
+ args.push_back(Value(nullptr, to_dir));
+ args.push_back(Value(nullptr, from_dir));
Err err;
FunctionCallNode function;
@@ -138,11 +138,11 @@ TEST(RebasePath, List) {
setup.scope()->set_source_dir(SourceDir("//tools/gn/"));
std::vector<Value> args;
- args.push_back(Value(NULL, Value::LIST));
- args[0].list_value().push_back(Value(NULL, "foo.txt"));
- args[0].list_value().push_back(Value(NULL, "bar.txt"));
- args.push_back(Value(NULL, "//out/Debug/"));
- args.push_back(Value(NULL, "."));
+ args.push_back(Value(nullptr, Value::LIST));
+ args[0].list_value().push_back(Value(nullptr, "foo.txt"));
+ args[0].list_value().push_back(Value(nullptr, "bar.txt"));
+ args.push_back(Value(nullptr, "//out/Debug/"));
+ args.push_back(Value(nullptr, "."));
Err err;
FunctionCallNode function;
« no previous file with comments | « tools/gn/function_process_file_template_unittest.cc ('k') | tools/gn/function_set_default_toolchain.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698