Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Unified Diff: tools/gn/exec_process.cc

Issue 798333005: tools/gn: Pass clang-modernize -use-nullptr over it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address Brett's review - revert some clang-format changes Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/escape_unittest.cc ('k') | tools/gn/filesystem_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/exec_process.cc
diff --git a/tools/gn/exec_process.cc b/tools/gn/exec_process.cc
index 701d87804e3fd895be5d5199069efa2ff25a05c5..2c2ad1df2d43460e662637c9b5e1c7408165112d 100644
--- a/tools/gn/exec_process.cc
+++ b/tools/gn/exec_process.cc
@@ -205,7 +205,7 @@ bool ExecProcess(const CommandLine& cmdline,
for (size_t i = 0; i < argv.size(); i++)
argv_cstr[i] = const_cast<char*>(argv[i].c_str());
- argv_cstr[argv.size()] = NULL;
+ argv_cstr[argv.size()] = nullptr;
execvp(argv_cstr[0], argv_cstr.get());
_exit(127);
}
@@ -225,10 +225,7 @@ bool ExecProcess(const CommandLine& cmdline,
FD_SET(err_read.get(), &read_fds);
int res =
HANDLE_EINTR(select(std::max(out_read.get(), err_read.get()) + 1,
- &read_fds,
- NULL,
- NULL,
- NULL));
+ &read_fds, nullptr, nullptr, nullptr));
if (res <= 0)
break;
if (FD_ISSET(out_read.get(), &read_fds))
« no previous file with comments | « tools/gn/escape_unittest.cc ('k') | tools/gn/filesystem_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698