tools/gn/function_get_label_info_unittest.cc - Issue 798333005: tools/gn: Pass clang-modernize -use-nullptr over it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/function_get_label_info_unittest.cc

Issue 798333005: tools/gn: Pass clang-modernize -use-nullptr over it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address Brett's review - revert some clang-format changes Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/gn/function_get_label_info_unittest.cc

diff --git a/tools/gn/function_get_label_info_unittest.cc b/tools/gn/function_get_label_info_unittest.cc

index 0499dd61d0c420946e71898b970dbb28e6c99483..42fe2233688c33d93e5f59370ad03961ef32df35 100644

--- a/tools/gn/function_get_label_info_unittest.cc

+++ b/tools/gn/function_get_label_info_unittest.cc

@@ -19,8 +19,8 @@ class GetLabelInfoTest : public testing::Test {

FunctionCallNode function;

std::vector<Value> args;

- args.push_back(Value(NULL, label));

- args.push_back(Value(NULL, what));

+ args.push_back(Value(nullptr, label));

+ args.push_back(Value(nullptr, what));

Err err;

Value result = functions::RunGetLabelInfo(setup_.scope(), &function,

« no previous file with comments | « tools/gn/function_foreach.cc ('k') | tools/gn/function_get_path_info_unittest.cc » ('j') | no next file with comments »