tools/gn/operators_unittest.cc - Issue 798333005: tools/gn: Pass clang-modernize -use-nullptr over it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/operators_unittest.cc

Issue 798333005: tools/gn: Pass clang-modernize -use-nullptr over it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address Brett's review - revert some clang-format changes Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/gn/operators_unittest.cc

diff --git a/tools/gn/operators_unittest.cc b/tools/gn/operators_unittest.cc

index d2af8b13f3827f20cdab85e6aebb28bd48d68e04..b5b3b0201471895b5e055bf4c455150c7bef5678 100644

--- a/tools/gn/operators_unittest.cc

+++ b/tools/gn/operators_unittest.cc

@@ -39,7 +39,7 @@ TEST(Operators, SourcesAppend) {

// Set up "sources" with an empty list.

const char sources[] = "sources";

- setup.scope()->SetValue(sources, Value(NULL, Value::LIST), NULL);

+ setup.scope()->SetValue(sources, Value(nullptr, Value::LIST), nullptr);

// Set up the operator.

BinaryOpNode node;

@@ -102,7 +102,7 @@ TEST(Operators, ListAppend) {

// Set up "foo" with an empty list.

const char foo[] = "foo";

- setup.scope()->SetValue(foo, Value(NULL, Value::LIST), NULL);

+ setup.scope()->SetValue(foo, Value(nullptr, Value::LIST), nullptr);

// Set up the operator.

BinaryOpNode node;

« no previous file with comments | « tools/gn/ninja_copy_target_writer.cc ('k') | tools/gn/parse_tree.cc » ('j') | no next file with comments »