Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 699943003: Move GrInvariantOutput out of GrProcessor and into its own class. (Closed)

Created:
6 years, 1 month ago by egdaniel
Modified:
6 years, 1 month ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Move GrInvariantOutput out of GrProcessor and into its own class. This will help with the ability to subclass, add to, etc. GrInvariantOutput. Also it was simply getting a little too big to be a "supporting" subclass BUG=skia: Committed: https://skia.googlesource.com/skia/+/605dd0fbce9dbb2a0d3313e13e161f2bd54870d7

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove friends and make GrInvariantOutput public #

Patch Set 3 : Updates #

Patch Set 4 : Updates #

Patch Set 5 : Cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+401 lines, -326 lines) Patch
M gyp/gpu.gypi View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
A include/gpu/GrInvariantOutput.h View 1 2 3 4 1 chunk +148 lines, -0 lines 0 comments Download
M include/gpu/GrProcessor.h View 4 chunks +3 lines, -140 lines 0 comments Download
M src/core/SkXfermode.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M src/effects/SkAlphaThresholdFilter.cpp View 1 3 chunks +3 lines, -2 lines 0 comments Download
M src/effects/SkArithmeticMode.cpp View 3 chunks +4 lines, -3 lines 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 5 chunks +5 lines, -4 lines 0 comments Download
M src/effects/SkColorCubeFilter.cpp View 4 chunks +5 lines, -3 lines 0 comments Download
M src/effects/SkColorFilters.cpp View 4 chunks +5 lines, -4 lines 0 comments Download
M src/effects/SkColorMatrixFilter.cpp View 4 chunks +4 lines, -3 lines 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 3 chunks +4 lines, -3 lines 0 comments Download
M src/effects/SkLightingImageFilter.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M src/effects/SkLumaColorFilter.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M src/effects/SkMagnifierImageFilter.cpp View 3 chunks +3 lines, -2 lines 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 1 3 chunks +3 lines, -2 lines 0 comments Download
M src/effects/SkPerlinNoiseShader.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M src/effects/SkTableColorFilter.cpp View 4 chunks +4 lines, -3 lines 0 comments Download
M src/effects/gradients/SkGradientShader.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M src/effects/gradients/SkGradientShaderPriv.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/gpu/GrAAConvexPathRenderer.cpp View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M src/gpu/GrAARectRenderer.cpp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrDefaultGeoProcFactory.cpp View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M src/gpu/GrDrawState.cpp View 1 2 3 4 chunks +22 lines, -20 lines 0 comments Download
A src/gpu/GrInvariantOutput.cpp View 1 chunk +56 lines, -0 lines 0 comments Download
M src/gpu/GrOptDrawState.cpp View 1 2 3 3 chunks +15 lines, -13 lines 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 1 2 3 4 chunks +4 lines, -3 lines 0 comments Download
M src/gpu/GrPaint.cpp View 1 2 3 4 chunks +10 lines, -12 lines 0 comments Download
M src/gpu/GrProcessor.cpp View 1 2 3 2 chunks +6 lines, -44 lines 0 comments Download
M src/gpu/effects/GrBezierEffect.h View 4 chunks +4 lines, -3 lines 0 comments Download
M src/gpu/effects/GrBicubicEffect.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/gpu/effects/GrBicubicEffect.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M src/gpu/effects/GrConvexPolyEffect.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/gpu/effects/GrConvexPolyEffect.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/effects/GrConvolutionEffect.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/gpu/effects/GrCustomCoordsTextureEffect.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/gpu/effects/GrCustomCoordsTextureEffect.cpp View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M src/gpu/effects/GrDashingEffect.cpp View 1 2 3 5 chunks +5 lines, -4 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldTextureEffect.h View 4 chunks +4 lines, -3 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldTextureEffect.cpp View 1 2 3 4 chunks +4 lines, -3 lines 0 comments Download
M src/gpu/effects/GrDitherEffect.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/effects/GrMatrixConvolutionEffect.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/gpu/effects/GrOvalEffect.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/effects/GrRRectEffect.cpp View 5 chunks +5 lines, -4 lines 0 comments Download
M src/gpu/effects/GrSimpleTextureEffect.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/gpu/effects/GrSimpleTextureEffect.cpp View 2 chunks +5 lines, -4 lines 0 comments Download
M src/gpu/effects/GrSingleTextureEffect.h View 2 chunks +3 lines, -2 lines 0 comments Download
M src/gpu/effects/GrTextureDomain.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/gpu/effects/GrTextureDomain.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M src/gpu/effects/GrYUVtoRGBEffect.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M tests/GLProgramsTest.cpp View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M tests/GpuColorFilterTest.cpp View 1 2 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
egdaniel
6 years, 1 month ago (2014-11-04 19:08:41 UTC) #2
bsalomon
lgtm, tiny nit and q's. https://codereview.chromium.org/699943003/diff/1/src/gpu/GrInvariantOutput.h File src/gpu/GrInvariantOutput.h (right): https://codereview.chromium.org/699943003/diff/1/src/gpu/GrInvariantOutput.h#newcode13 src/gpu/GrInvariantOutput.h:13: class GrInvariantOutput{ missing space ...
6 years, 1 month ago (2014-11-04 19:57:05 UTC) #3
egdaniel
just looking for a quick review since there has been a couple changes and a ...
6 years, 1 month ago (2014-11-12 14:32:39 UTC) #4
bsalomon
lgtm
6 years, 1 month ago (2014-11-12 14:44:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/699943003/80001
6 years, 1 month ago (2014-11-12 16:27:05 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-12 16:35:31 UTC) #8
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/605dd0fbce9dbb2a0d3313e13e161f2bd54870d7

Powered by Google App Engine
This is Rietveld 408576698