Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 332543002: Rename Repaint to Paint Invalidation Part 4 (Closed)

Created:
6 years, 6 months ago by dsinclair
Modified:
6 years, 6 months ago
CC:
blink-layers+watch_chromium.org, blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, blink-reviews-rendering, cbiesinger, chromiumbugtracker_adobe.com, dglazkov+blink, krit, eae+blinkwatch, ed+blinkwatch_opera.com, f(malita), fs, gyuyoung.kim_webkit.org, jchaffraix+rendering, jfernandez, kouhei+svg_chromium.org, leviw+renderwatch, pdr., Manuel Rego, rwlbuis, rune+blink, Stephen Chennney, sof, svillar, zoltan1
Visibility:
Public.

Description

Rename Repaint to Paint Invalidation Part 4 This CL renames the remaining methods in RenderObject which used repaint to be paint invalidation. BUG=338691 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176033

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+442 lines, -442 lines) Patch
M Source/core/dom/Element.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/FrameView.cpp View 7 chunks +8 lines, -8 lines 0 comments Download
M Source/core/html/HTMLFrameSetElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLInputElement.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTableColElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTextAreaElement.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/forms/NumberInputType.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/forms/RangeInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/shadow/SliderThumbElement.cpp View 1 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/rendering/FastTextAutosizer.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/LayoutRepainter.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderBR.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderBlock.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/rendering/RenderBlock.cpp View 9 chunks +14 lines, -14 lines 0 comments Download
M Source/core/rendering/RenderBlockFlow.cpp View 1 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/rendering/RenderBlockLineLayout.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderBox.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderBox.cpp View 8 chunks +18 lines, -18 lines 0 comments Download
M Source/core/rendering/RenderCounter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderDeprecatedFlexibleBox.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderFieldset.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderFlexibleBox.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderFlowThread.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderFrameSet.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M Source/core/rendering/RenderFullScreen.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/rendering/RenderGrid.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderHTMLCanvas.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderImage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderInline.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderInline.cpp View 1 12 chunks +24 lines, -24 lines 0 comments Download
M Source/core/rendering/RenderLayer.cpp View 1 5 chunks +6 lines, -6 lines 0 comments Download
M Source/core/rendering/RenderLayerModelObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderLayerRepainter.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderLayerRepainter.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M Source/core/rendering/RenderLayerScrollableArea.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderListBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderListItem.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderListMarker.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderListMarker.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/rendering/RenderMarquee.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderMenuList.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderObject.h View 22 chunks +54 lines, -54 lines 0 comments Download
M Source/core/rendering/RenderObject.cpp View 36 chunks +85 lines, -85 lines 0 comments Download
M Source/core/rendering/RenderObjectChildList.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderReplaced.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderReplaced.cpp View 6 chunks +7 lines, -7 lines 0 comments Download
M Source/core/rendering/RenderRubyBase.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderSelectionInfo.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderTable.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderTable.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderTableCell.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderTableCell.cpp View 4 chunks +9 lines, -9 lines 0 comments Download
M Source/core/rendering/RenderTableCol.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderTableCol.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/rendering/RenderTableRow.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderTableSection.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderText.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderText.cpp View 5 chunks +10 lines, -10 lines 0 comments Download
M Source/core/rendering/RenderTextControlSingleLine.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderVideo.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderView.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderView.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/rendering/SubtreeLayoutScope.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGBlock.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGBlock.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGContainer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGContainer.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGForeignObject.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGForeignObject.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGGradientStop.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGHiddenContainer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGImage.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGImage.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGInline.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGInline.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGInlineText.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGModelObject.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGModelObject.cpp View 1 4 chunks +9 lines, -9 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceClipper.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceContainer.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceMarker.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceMasker.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGRoot.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGRoot.cpp View 5 chunks +13 lines, -13 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGShape.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGShape.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGText.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGText.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/rendering/svg/SVGRenderSupport.cpp View 1 4 chunks +6 lines, -6 lines 0 comments Download
M Source/core/rendering/svg/SVGRenderingContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGClipPathElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGElement.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFilterElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGGradientElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGMarkerElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGMaskElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPatternElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGSVGElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/graphics/filters/SVGFEImage.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
dsinclair
PTAL. This finishes off the renaming of methods in RenderObject.
6 years, 6 months ago (2014-06-11 20:44:10 UTC) #1
esprehn
rslgtm, the bike shed is now fully painted!
6 years, 6 months ago (2014-06-11 23:35:53 UTC) #2
dsinclair
The CQ bit was checked by dsinclair@chromium.org
6 years, 6 months ago (2014-06-12 13:30:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dsinclair@chromium.org/332543002/1
6 years, 6 months ago (2014-06-12 13:30:54 UTC) #4
dsinclair
The CQ bit was checked by dsinclair@chromium.org
6 years, 6 months ago (2014-06-12 13:57:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dsinclair@chromium.org/332543002/30101
6 years, 6 months ago (2014-06-12 13:58:02 UTC) #6
dsinclair
The CQ bit was unchecked by dsinclair@chromium.org
6 years, 6 months ago (2014-06-12 13:59:00 UTC) #7
dsinclair
The CQ bit was checked by dsinclair@chromium.org
6 years, 6 months ago (2014-06-12 13:59:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dsinclair@chromium.org/332543002/30101
6 years, 6 months ago (2014-06-12 13:59:50 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 6 months ago (2014-06-12 15:04:41 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-12 15:05:03 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/16551)
6 years, 6 months ago (2014-06-12 15:05:05 UTC) #12
dsinclair
The CQ bit was checked by dsinclair@chromium.org
6 years, 6 months ago (2014-06-12 15:40:00 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dsinclair@chromium.org/332543002/30101
6 years, 6 months ago (2014-06-12 15:41:02 UTC) #14
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 16:02:25 UTC) #15
Message was sent while issue was closed.
Change committed as 176033

Powered by Google App Engine
This is Rietveld 408576698