Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Side by Side Diff: Source/core/rendering/svg/RenderSVGModelObject.cpp

Issue 332543002: Rename Repaint to Paint Invalidation Part 4 (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2009, Google Inc. All rights reserved. 2 * Copyright (c) 2009, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
43 RenderSVGModelObject::RenderSVGModelObject(SVGElement* node) 43 RenderSVGModelObject::RenderSVGModelObject(SVGElement* node)
44 : RenderObject(node) 44 : RenderObject(node)
45 { 45 {
46 } 46 }
47 47
48 bool RenderSVGModelObject::isChildAllowed(RenderObject* child, RenderStyle*) con st 48 bool RenderSVGModelObject::isChildAllowed(RenderObject* child, RenderStyle*) con st
49 { 49 {
50 return child->isSVG() && !(child->isSVGInline() || child->isSVGInlineText()) ; 50 return child->isSVG() && !(child->isSVGInline() || child->isSVGInlineText()) ;
51 } 51 }
52 52
53 LayoutRect RenderSVGModelObject::clippedOverflowRectForRepaint(const RenderLayer ModelObject* repaintContainer) const 53 LayoutRect RenderSVGModelObject::clippedOverflowRectForPaintInvalidation(const R enderLayerModelObject* paintInvalidationContainer) const
54 { 54 {
55 return SVGRenderSupport::clippedOverflowRectForRepaint(this, repaintContaine r); 55 return SVGRenderSupport::clippedOverflowRectForRepaint(this, paintInvalidati onContainer);
56 } 56 }
57 57
58 void RenderSVGModelObject::computeFloatRectForRepaint(const RenderLayerModelObje ct* repaintContainer, FloatRect& repaintRect, bool fixed) const 58 void RenderSVGModelObject::computeFloatRectForPaintInvalidation(const RenderLaye rModelObject* paintInvalidationContainer, FloatRect& paintInvalidationRect, bool fixed) const
59 { 59 {
60 SVGRenderSupport::computeFloatRectForRepaint(this, repaintContainer, repaint Rect, fixed); 60 SVGRenderSupport::computeFloatRectForRepaint(this, paintInvalidationContaine r, paintInvalidationRect, fixed);
61 } 61 }
62 62
63 void RenderSVGModelObject::mapLocalToContainer(const RenderLayerModelObject* rep aintContainer, TransformState& transformState, MapCoordinatesFlags, bool* wasFix ed) const 63 void RenderSVGModelObject::mapLocalToContainer(const RenderLayerModelObject* rep aintContainer, TransformState& transformState, MapCoordinatesFlags, bool* wasFix ed) const
64 { 64 {
65 SVGRenderSupport::mapLocalToContainer(this, repaintContainer, transformState , wasFixed); 65 SVGRenderSupport::mapLocalToContainer(this, repaintContainer, transformState , wasFixed);
66 } 66 }
67 67
68 const RenderObject* RenderSVGModelObject::pushMappingToContainer(const RenderLay erModelObject* ancestorToStopAt, RenderGeometryMap& geometryMap) const 68 const RenderObject* RenderSVGModelObject::pushMappingToContainer(const RenderLay erModelObject* ancestorToStopAt, RenderGeometryMap& geometryMap) const
69 { 69 {
70 return SVGRenderSupport::pushMappingToContainer(this, ancestorToStopAt, geom etryMap); 70 return SVGRenderSupport::pushMappingToContainer(this, ancestorToStopAt, geom etryMap);
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
114 bool RenderSVGModelObject::nodeAtPoint(const HitTestRequest&, HitTestResult&, co nst HitTestLocation&, const LayoutPoint&, HitTestAction) 114 bool RenderSVGModelObject::nodeAtPoint(const HitTestRequest&, HitTestResult&, co nst HitTestLocation&, const LayoutPoint&, HitTestAction)
115 { 115 {
116 ASSERT_NOT_REACHED(); 116 ASSERT_NOT_REACHED();
117 return false; 117 return false;
118 } 118 }
119 119
120 // The SVG addFocusRingRects() method adds rects in local coordinates so the def ault absoluteFocusRingQuads 120 // The SVG addFocusRingRects() method adds rects in local coordinates so the def ault absoluteFocusRingQuads
121 // returns incorrect values for SVG objects. Overriding this method provides acc ess to the absolute bounds. 121 // returns incorrect values for SVG objects. Overriding this method provides acc ess to the absolute bounds.
122 void RenderSVGModelObject::absoluteFocusRingQuads(Vector<FloatQuad>& quads) 122 void RenderSVGModelObject::absoluteFocusRingQuads(Vector<FloatQuad>& quads)
123 { 123 {
124 quads.append(localToAbsoluteQuad(FloatQuad(repaintRectInLocalCoordinates())) ); 124 quads.append(localToAbsoluteQuad(FloatQuad(paintInvalidationRectInLocalCoord inates())));
125 } 125 }
126 126
127 void RenderSVGModelObject::invalidateTreeAfterLayout(const RenderLayerModelObjec t& paintInvalidationContainer) 127 void RenderSVGModelObject::invalidateTreeAfterLayout(const RenderLayerModelObjec t& paintInvalidationContainer)
128 { 128 {
129 // Note: This is a reduced version of RenderBox::invalidateTreeAfterLayout() . 129 // Note: This is a reduced version of RenderBox::invalidateTreeAfterLayout() .
130 // FIXME: Should share code with RenderBox::invalidateTreeAfterLayout(). 130 // FIXME: Should share code with RenderBox::invalidateTreeAfterLayout().
131 ASSERT(RuntimeEnabledFeatures::repaintAfterLayoutEnabled()); 131 ASSERT(RuntimeEnabledFeatures::repaintAfterLayoutEnabled());
132 ASSERT(!needsLayout()); 132 ASSERT(!needsLayout());
133 133
134 if (!shouldCheckForPaintInvalidationAfterLayout()) 134 if (!shouldCheckForPaintInvalidationAfterLayout())
135 return; 135 return;
136 136
137 LayoutStateDisabler layoutStateDisabler(*this); 137 LayoutStateDisabler layoutStateDisabler(*this);
138 138
139 const LayoutRect oldPaintInvalidationRect = previousPaintInvalidationRect(); 139 const LayoutRect oldPaintInvalidationRect = previousPaintInvalidationRect();
140 const LayoutPoint oldPositionFromPaintInvalidationContainer = previousPositi onFromPaintInvalidationContainer(); 140 const LayoutPoint oldPositionFromPaintInvalidationContainer = previousPositi onFromPaintInvalidationContainer();
141 const RenderLayerModelObject& newPaintInvalidationContainer = *containerForR epaint(); 141 const RenderLayerModelObject& newPaintInvalidationContainer = *containerForP aintInvalidation();
142 setPreviousPaintInvalidationRect(clippedOverflowRectForRepaint(&newPaintInva lidationContainer)); 142 setPreviousPaintInvalidationRect(clippedOverflowRectForPaintInvalidation(&ne wPaintInvalidationContainer));
143 setPreviousPositionFromPaintInvalidationContainer(positionFromRepaintContain er(&newPaintInvalidationContainer)); 143 setPreviousPositionFromPaintInvalidationContainer(positionFromPaintInvalidat ionContainer(&newPaintInvalidationContainer));
144 144
145 // If an ancestor container had its transform changed, then we just 145 // If an ancestor container had its transform changed, then we just
146 // need to update the RenderSVGModelObject's repaint rect above. The invalid ation 146 // need to update the RenderSVGModelObject's repaint rect above. The invalid ation
147 // will be handled by the container where the transform changed. This essent ially 147 // will be handled by the container where the transform changed. This essent ially
148 // means that we prune the entire branch for performance. 148 // means that we prune the entire branch for performance.
149 if (!SVGRenderSupport::parentTransformDidChange(this)) 149 if (!SVGRenderSupport::parentTransformDidChange(this))
150 return; 150 return;
151 151
152 // If we are set to do a full paint invalidation that means the RenderView w ill be 152 // If we are set to do a full paint invalidation that means the RenderView w ill be
153 // issue paint invalidations. We can then skip issuing of paint invalidation s for the child 153 // issue paint invalidations. We can then skip issuing of paint invalidation s for the child
154 // renderers as they'll be covered by the RenderView. 154 // renderers as they'll be covered by the RenderView.
155 if (view()->doingFullRepaint()) { 155 if (view()->doingFullRepaint()) {
156 RenderObject::invalidateTreeAfterLayout(newPaintInvalidationContainer); 156 RenderObject::invalidateTreeAfterLayout(newPaintInvalidationContainer);
157 return; 157 return;
158 } 158 }
159 159
160 const LayoutRect& newPaintInvalidationRect = previousPaintInvalidationRect() ; 160 const LayoutRect& newPaintInvalidationRect = previousPaintInvalidationRect() ;
161 const LayoutPoint& newPositionFromPaintInvalidationContainer = previousPosit ionFromPaintInvalidationContainer(); 161 const LayoutPoint& newPositionFromPaintInvalidationContainer = previousPosit ionFromPaintInvalidationContainer();
162 invalidatePaintAfterLayoutIfNeeded(containerForRepaint(), 162 invalidatePaintAfterLayoutIfNeeded(containerForPaintInvalidation(),
163 shouldDoFullPaintInvalidationAfterLayout(), oldPaintInvalidationRect, ol dPositionFromPaintInvalidationContainer, 163 shouldDoFullPaintInvalidationAfterLayout(), oldPaintInvalidationRect, ol dPositionFromPaintInvalidationContainer,
164 &newPaintInvalidationRect, &newPositionFromPaintInvalidationContainer); 164 &newPaintInvalidationRect, &newPositionFromPaintInvalidationContainer);
165 165
166 RenderObject::invalidateTreeAfterLayout(newPaintInvalidationContainer); 166 RenderObject::invalidateTreeAfterLayout(newPaintInvalidationContainer);
167 } 167 }
168 168
169 } // namespace WebCore 169 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/rendering/svg/RenderSVGModelObject.h ('k') | Source/core/rendering/svg/RenderSVGResource.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698