Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Side by Side Diff: Source/core/rendering/RenderObjectChildList.cpp

Issue 332543002: Rename Repaint to Paint Invalidation Part 4 (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/rendering/RenderObject.cpp ('k') | Source/core/rendering/RenderReplaced.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009, 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2009, 2010 Apple Inc. All rights reserved.
3 * Copyright (C) Research In Motion Limited 2010. All rights reserved. 3 * Copyright (C) Research In Motion Limited 2010. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
57 toRenderBox(oldChild)->removeFloatingOrPositionedChildFromBlockLists(); 57 toRenderBox(oldChild)->removeFloatingOrPositionedChildFromBlockLists();
58 58
59 { 59 {
60 // FIXME: We should not be allowing repaint during layout. crbug.com/336 250 60 // FIXME: We should not be allowing repaint during layout. crbug.com/336 250
61 AllowPaintInvalidationScope scoper(owner->frameView()); 61 AllowPaintInvalidationScope scoper(owner->frameView());
62 62
63 // So that we'll get the appropriate dirty bit set (either that a normal flow child got yanked or 63 // So that we'll get the appropriate dirty bit set (either that a normal flow child got yanked or
64 // that a positioned child got yanked). We also repaint, so that the are a exposed when the child 64 // that a positioned child got yanked). We also repaint, so that the are a exposed when the child
65 // disappears gets repainted properly. 65 // disappears gets repainted properly.
66 if (!owner->documentBeingDestroyed() && notifyRenderer && oldChild->ever HadLayout()) { 66 if (!owner->documentBeingDestroyed() && notifyRenderer && oldChild->ever HadLayout()) {
67 oldChild->setNeedsLayoutAndPrefWidthsRecalcAndFullRepaint(); 67 oldChild->setNeedsLayoutAndPrefWidthsRecalcAndFullPaintInvalidation( );
68 // We only repaint |oldChild| if we have a RenderLayer as its visual overflow may not be tracked by its parent. 68 // We only repaint |oldChild| if we have a RenderLayer as its visual overflow may not be tracked by its parent.
69 if (oldChild->isBody()) 69 if (oldChild->isBody())
70 owner->view()->paintInvalidationForWholeRenderer(); 70 owner->view()->paintInvalidationForWholeRenderer();
71 else 71 else
72 oldChild->paintInvalidationForWholeRenderer(); 72 oldChild->paintInvalidationForWholeRenderer();
73 } 73 }
74 } 74 }
75 75
76 // If we have a line box wrapper, delete it. 76 // If we have a line box wrapper, delete it.
77 if (oldChild->isBox()) 77 if (oldChild->isBox())
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
151 setLastChild(newChild); 151 setLastChild(newChild);
152 } 152 }
153 153
154 if (!owner->documentBeingDestroyed() && notifyRenderer) 154 if (!owner->documentBeingDestroyed() && notifyRenderer)
155 newChild->insertedIntoTree(); 155 newChild->insertedIntoTree();
156 156
157 if (!owner->documentBeingDestroyed()) { 157 if (!owner->documentBeingDestroyed()) {
158 RenderCounter::rendererSubtreeAttached(newChild); 158 RenderCounter::rendererSubtreeAttached(newChild);
159 } 159 }
160 160
161 newChild->setNeedsLayoutAndPrefWidthsRecalcAndFullRepaint(); 161 newChild->setNeedsLayoutAndPrefWidthsRecalcAndFullPaintInvalidation();
162 if (!owner->normalChildNeedsLayout()) 162 if (!owner->normalChildNeedsLayout())
163 owner->setChildNeedsLayout(); // We may supply the static position for a n absolute positioned child. 163 owner->setChildNeedsLayout(); // We may supply the static position for a n absolute positioned child.
164 164
165 if (AXObjectCache* cache = owner->document().axObjectCache()) 165 if (AXObjectCache* cache = owner->document().axObjectCache())
166 cache->childrenChanged(owner); 166 cache->childrenChanged(owner);
167 } 167 }
168 168
169 } // namespace WebCore 169 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderObject.cpp ('k') | Source/core/rendering/RenderReplaced.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698