| Index: Source/core/rendering/RenderObject.cpp
|
| diff --git a/Source/core/rendering/RenderObject.cpp b/Source/core/rendering/RenderObject.cpp
|
| index 8af9654ff0c4478729b17127b9fc3405836b3043..1de82be21a94517a11222fe0a1bc68bee7563242 100644
|
| --- a/Source/core/rendering/RenderObject.cpp
|
| +++ b/Source/core/rendering/RenderObject.cpp
|
| @@ -126,8 +126,8 @@ struct SameSizeAsRenderObject {
|
| #endif
|
| unsigned m_bitfields;
|
| unsigned m_bitfields2;
|
| - LayoutRect rect; // Stores the previous repaint rect.
|
| - LayoutPoint position; // Stores the previous position from the repaint container.
|
| + LayoutRect rect; // Stores the previous paint invalidation rect.
|
| + LayoutPoint position; // Stores the previous position from the paint invalidation container.
|
| };
|
|
|
| COMPILE_ASSERT(sizeof(RenderObject) == sizeof(SameSizeAsRenderObject), RenderObject_should_stay_small);
|
| @@ -749,22 +749,22 @@ void RenderObject::invalidateContainerPreferredLogicalWidths()
|
| }
|
| }
|
|
|
| -void RenderObject::setLayerNeedsFullRepaintForPositionedMovementLayout()
|
| +void RenderObject::setLayerNeedsFullPaintInvalidationForPositionedMovementLayout()
|
| {
|
| ASSERT(hasLayer());
|
| toRenderLayerModelObject(this)->layer()->repainter().setRepaintStatus(NeedsFullRepaintForPositionedMovementLayout);
|
| }
|
|
|
| -RenderBlock* RenderObject::containerForFixedPosition(const RenderLayerModelObject* repaintContainer, bool* repaintContainerSkipped) const
|
| +RenderBlock* RenderObject::containerForFixedPosition(const RenderLayerModelObject* paintInvalidationContainer, bool* paintInvalidationContainerSkipped) const
|
| {
|
| - ASSERT(!repaintContainerSkipped || !*repaintContainerSkipped);
|
| + ASSERT(!paintInvalidationContainerSkipped || !*paintInvalidationContainerSkipped);
|
| ASSERT(!isText());
|
| ASSERT(style()->position() == FixedPosition);
|
|
|
| RenderObject* ancestor = parent();
|
| for (; ancestor && !ancestor->canContainFixedPositionObjects(); ancestor = ancestor->parent()) {
|
| - if (repaintContainerSkipped && ancestor == repaintContainer)
|
| - *repaintContainerSkipped = true;
|
| + if (paintInvalidationContainerSkipped && ancestor == paintInvalidationContainer)
|
| + *paintInvalidationContainerSkipped = true;
|
| }
|
|
|
| ASSERT(!ancestor || !ancestor->isAnonymousBlock());
|
| @@ -846,7 +846,7 @@ bool RenderObject::canRenderBorderImage() const
|
| return borderImage && borderImage->canRender(*this, style()->effectiveZoom()) && borderImage->isLoaded();
|
| }
|
|
|
| -bool RenderObject::mustRepaintFillLayersOnWidthChange(const FillLayer& layer) const
|
| +bool RenderObject::mustInvalidateFillLayersPaintOnWidthChange(const FillLayer& layer) const
|
| {
|
| // Nobody will use multiple layers without wanting fancy positioning.
|
| if (layer.next())
|
| @@ -883,7 +883,7 @@ bool RenderObject::mustRepaintFillLayersOnWidthChange(const FillLayer& layer) co
|
| return false;
|
| }
|
|
|
| -bool RenderObject::mustRepaintFillLayersOnHeightChange(const FillLayer& layer) const
|
| +bool RenderObject::mustInvalidateFillLayersPaintOnHeightChange(const FillLayer& layer) const
|
| {
|
| // Nobody will use multiple layers without wanting fancy positioning.
|
| if (layer.next())
|
| @@ -920,16 +920,16 @@ bool RenderObject::mustRepaintFillLayersOnHeightChange(const FillLayer& layer) c
|
| return false;
|
| }
|
|
|
| -bool RenderObject::mustRepaintBackgroundOrBorderOnWidthChange() const
|
| +bool RenderObject::mustInvalidateBackgroundOrBorderPaintOnWidthChange() const
|
| {
|
| - if (hasMask() && mustRepaintFillLayersOnWidthChange(*style()->maskLayers()))
|
| + if (hasMask() && mustInvalidateFillLayersPaintOnWidthChange(*style()->maskLayers()))
|
| return true;
|
|
|
| // If we don't have a background/border/mask, then nothing to do.
|
| if (!hasBoxDecorations())
|
| return false;
|
|
|
| - if (mustRepaintFillLayersOnWidthChange(*style()->backgroundLayers()))
|
| + if (mustInvalidateFillLayersPaintOnWidthChange(*style()->backgroundLayers()))
|
| return true;
|
|
|
| // Our fill layers are ok. Let's check border.
|
| @@ -939,16 +939,16 @@ bool RenderObject::mustRepaintBackgroundOrBorderOnWidthChange() const
|
| return false;
|
| }
|
|
|
| -bool RenderObject::mustRepaintBackgroundOrBorderOnHeightChange() const
|
| +bool RenderObject::mustInvalidateBackgroundOrBorderPaintOnHeightChange() const
|
| {
|
| - if (hasMask() && mustRepaintFillLayersOnHeightChange(*style()->maskLayers()))
|
| + if (hasMask() && mustInvalidateFillLayersPaintOnHeightChange(*style()->maskLayers()))
|
| return true;
|
|
|
| // If we don't have a background/border/mask, then nothing to do.
|
| if (!hasBoxDecorations())
|
| return false;
|
|
|
| - if (mustRepaintFillLayersOnHeightChange(*style()->backgroundLayers()))
|
| + if (mustInvalidateFillLayersPaintOnHeightChange(*style()->backgroundLayers()))
|
| return true;
|
|
|
| // Our fill layers are ok. Let's check border.
|
| @@ -1337,16 +1337,16 @@ void RenderObject::addChildFocusRingRects(Vector<IntRect>& rects, const LayoutPo
|
| }
|
|
|
| // FIXME: In repaint-after-layout, we should be able to change the logic to remove the need for this function. See crbug.com/368416.
|
| -LayoutPoint RenderObject::positionFromRepaintContainer(const RenderLayerModelObject* repaintContainer) const
|
| +LayoutPoint RenderObject::positionFromPaintInvalidationContainer(const RenderLayerModelObject* paintInvalidationContainer) const
|
| {
|
| - // FIXME: This assert should be re-enabled when we move repaint to after compositing update. crbug.com/360286
|
| - // ASSERT(containerForRepaint() == repaintContainer);
|
| + // FIXME: This assert should be re-enabled when we move paint invalidation to after compositing update. crbug.com/360286
|
| + // ASSERT(containerForPaintInvalidation() == paintInvalidationContainer);
|
|
|
| LayoutPoint offset = isBox() ? toRenderBox(this)->location() : LayoutPoint();
|
| - if (repaintContainer == this)
|
| + if (paintInvalidationContainer == this)
|
| return offset;
|
|
|
| - return roundedIntPoint(localToContainerPoint(offset, repaintContainer));
|
| + return roundedIntPoint(localToContainerPoint(offset, paintInvalidationContainer));
|
| }
|
|
|
| IntRect RenderObject::absoluteBoundingBoxRect() const
|
| @@ -1383,7 +1383,7 @@ IntRect RenderObject::absoluteBoundingBoxRectIgnoringTransforms() const
|
| void RenderObject::absoluteFocusRingQuads(Vector<FloatQuad>& quads)
|
| {
|
| Vector<IntRect> rects;
|
| - const RenderLayerModelObject* container = containerForRepaint();
|
| + const RenderLayerModelObject* container = containerForPaintInvalidation();
|
| addFocusRingRects(rects, LayoutPoint(localToContainerPoint(FloatPoint(), container)), container);
|
| size_t count = rects.size();
|
| for (size_t i = 0; i < count; ++i)
|
| @@ -1428,7 +1428,7 @@ void RenderObject::paint(PaintInfo&, const LayoutPoint&)
|
| {
|
| }
|
|
|
| -const RenderLayerModelObject* RenderObject::containerForRepaint() const
|
| +const RenderLayerModelObject* RenderObject::containerForPaintInvalidation() const
|
| {
|
| if (!isRooted())
|
| return 0;
|
| @@ -1449,7 +1449,7 @@ const RenderLayerModelObject* RenderObject::enclosingCompositedContainer() const
|
| return container;
|
| }
|
|
|
| -const RenderLayerModelObject* RenderObject::adjustCompositedContainerForSpecialAncestors(const RenderLayerModelObject* repaintContainer) const
|
| +const RenderLayerModelObject* RenderObject::adjustCompositedContainerForSpecialAncestors(const RenderLayerModelObject* paintInvalidationContainer) const
|
| {
|
|
|
| if (document().view()->hasSoftwareFilters()) {
|
| @@ -1457,19 +1457,19 @@ const RenderLayerModelObject* RenderObject::adjustCompositedContainerForSpecialA
|
| return enclosingFilterLayer->renderer();
|
| }
|
|
|
| - // If we have a flow thread, then we need to do individual repaints within the RenderRegions instead.
|
| - // Return the flow thread as a repaint container in order to create a chokepoint that allows us to change
|
| - // repainting to do individual region repaints.
|
| + // If we have a flow thread, then we need to do individual paint invalidations within the RenderRegions instead.
|
| + // Return the flow thread as a paint invalidation container in order to create a chokepoint that allows us to change
|
| + // paint invalidation to do individual region paint invalidations.
|
| if (RenderFlowThread* parentRenderFlowThread = flowThreadContainingBlock()) {
|
| - // If we have already found a repaint container then we will repaint into that container only if it is part of the same
|
| - // flow thread. Otherwise we will need to catch the repaint call and send it to the flow thread.
|
| - if (!repaintContainer || repaintContainer->flowThreadContainingBlock() != parentRenderFlowThread)
|
| - repaintContainer = parentRenderFlowThread;
|
| + // If we have already found a paint invalidation container then we will invalidate paints in that container only if it is part of the same
|
| + // flow thread. Otherwise we will need to catch the paint invalidation call and send it to the flow thread.
|
| + if (!paintInvalidationContainer || paintInvalidationContainer->flowThreadContainingBlock() != parentRenderFlowThread)
|
| + paintInvalidationContainer = parentRenderFlowThread;
|
| }
|
| - return repaintContainer ? repaintContainer : view();
|
| + return paintInvalidationContainer ? paintInvalidationContainer : view();
|
| }
|
|
|
| -bool RenderObject::isRepaintContainer() const
|
| +bool RenderObject::isPaintInvalidationContainer() const
|
| {
|
| return hasLayer() && toRenderLayerModelObject(this)->layer()->isRepaintContainer();
|
| }
|
| @@ -1484,7 +1484,7 @@ template<typename T> PassRefPtr<JSONValue> jsonObjectForRect(const T& rect)
|
| return object.release();
|
| }
|
|
|
| -static PassRefPtr<JSONValue> jsonObjectForRepaintInfo(const IntRect& rect, const String& invalidationReason)
|
| +static PassRefPtr<JSONValue> jsonObjectForPaintInvalidationInfo(const IntRect& rect, const String& invalidationReason)
|
| {
|
| RefPtr<JSONObject> object = JSONObject::create();
|
| object->setValue("rect", jsonObjectForRect(rect));
|
| @@ -1492,9 +1492,9 @@ static PassRefPtr<JSONValue> jsonObjectForRepaintInfo(const IntRect& rect, const
|
| return object.release();
|
| }
|
|
|
| -LayoutRect RenderObject::computeRepaintRect(const RenderLayerModelObject* repaintContainer) const
|
| +LayoutRect RenderObject::computePaintInvalidationRect(const RenderLayerModelObject* paintInvalidationContainer) const
|
| {
|
| - return clippedOverflowRectForRepaint(repaintContainer);
|
| + return clippedOverflowRectForPaintInvalidation(paintInvalidationContainer);
|
| }
|
|
|
| void RenderObject::invalidatePaintUsingContainer(const RenderLayerModelObject* paintInvalidationContainer, const IntRect& r, InvalidationReason invalidationReason) const
|
| @@ -1509,7 +1509,7 @@ void RenderObject::invalidatePaintUsingContainer(const RenderLayerModelObject* p
|
|
|
| TRACE_EVENT2(TRACE_DISABLED_BY_DEFAULT("blink.invalidation"), "RenderObject::invalidatePaintUsingContainer()",
|
| "object", this->debugName().ascii(),
|
| - "info", TracedValue::fromJSONValue(jsonObjectForRepaintInfo(r, invalidationReasonToString(invalidationReason))));
|
| + "info", TracedValue::fromJSONValue(jsonObjectForPaintInvalidationInfo(r, invalidationReasonToString(invalidationReason))));
|
|
|
| // FIXME: Don't read compositing state here since we do this in the middle of recalc/layout.
|
| DisableCompositingQueryAsserts disabler;
|
| @@ -1557,16 +1557,16 @@ void RenderObject::paintInvalidationForWholeRenderer() const
|
| // FIXME: really, we're in the paint invalidation phase here, and the following queries are legal.
|
| // Until those states are fully fledged, I'll just disable the ASSERTS.
|
| DisableCompositingQueryAsserts disabler;
|
| - const RenderLayerModelObject* paintInvalidationContainer = containerForRepaint();
|
| - LayoutRect paintInvalidationRect = boundsRectForRepaint(paintInvalidationContainer);
|
| - invalidatePaintUsingContainer(paintInvalidationContainer, pixelSnappedIntRect(paintInvalidationRect), InvalidationRepaint);
|
| + const RenderLayerModelObject* paintInvalidationContainer = containerForPaintInvalidation();
|
| + LayoutRect paintInvalidationRect = boundsRectForPaintInvalidation(paintInvalidationContainer);
|
| + invalidatePaintUsingContainer(paintInvalidationContainer, pixelSnappedIntRect(paintInvalidationRect), InvalidationPaint);
|
| }
|
|
|
| -LayoutRect RenderObject::boundsRectForRepaint(const RenderLayerModelObject* repaintContainer) const
|
| +LayoutRect RenderObject::boundsRectForPaintInvalidation(const RenderLayerModelObject* paintInvalidationContainer) const
|
| {
|
| - if (!repaintContainer)
|
| - return computeRepaintRect(repaintContainer);
|
| - return RenderLayer::computeRepaintRect(this, repaintContainer->layer());
|
| + if (!paintInvalidationContainer)
|
| + return computePaintInvalidationRect(paintInvalidationContainer);
|
| + return RenderLayer::computeRepaintRect(this, paintInvalidationContainer->layer());
|
| }
|
|
|
| void RenderObject::invalidatePaintRectangle(const LayoutRect& r) const
|
| @@ -1585,9 +1585,9 @@ void RenderObject::invalidatePaintRectangle(const LayoutRect& r) const
|
| dirtyRect.move(view()->layoutDelta());
|
| }
|
|
|
| - const RenderLayerModelObject* paintInvalidationContainer = containerForRepaint();
|
| + const RenderLayerModelObject* paintInvalidationContainer = containerForPaintInvalidation();
|
| RenderLayer::mapRectToRepaintBacking(this, paintInvalidationContainer, dirtyRect);
|
| - invalidatePaintUsingContainer(paintInvalidationContainer, pixelSnappedIntRect(dirtyRect), InvalidationRepaintRectangle);
|
| + invalidatePaintUsingContainer(paintInvalidationContainer, pixelSnappedIntRect(dirtyRect), InvalidationPaintRectangle);
|
| }
|
|
|
| IntRect RenderObject::pixelSnappedAbsoluteClippedOverflowRect() const
|
| @@ -1618,9 +1618,9 @@ const char* RenderObject::invalidationReasonToString(InvalidationReason reason)
|
| return "selection";
|
| case InvalidationLayer:
|
| return "layer";
|
| - case InvalidationRepaint:
|
| + case InvalidationPaint:
|
| return "invalidate paint";
|
| - case InvalidationRepaintRectangle:
|
| + case InvalidationPaintRectangle:
|
| return "invalidate paint rectangle";
|
| }
|
| ASSERT_NOT_REACHED();
|
| @@ -1659,9 +1659,9 @@ bool RenderObject::invalidatePaintAfterLayoutIfNeeded(const RenderLayerModelObje
|
| return false; // Don't invalidate paints if we're printing.
|
|
|
| // This ASSERT fails due to animations. See https://bugs.webkit.org/show_bug.cgi?id=37048
|
| - // ASSERT(!newBoundsPtr || *newBoundsPtr == clippedOverflowRectForRepaint(paintInvalidationContainer));
|
| - LayoutRect newBounds = newBoundsPtr ? *newBoundsPtr : computeRepaintRect();
|
| - LayoutPoint newLocation = newLocationPtr ? (*newLocationPtr) : positionFromRepaintContainer(paintInvalidationContainer);
|
| + // ASSERT(!newBoundsPtr || *newBoundsPtr == clippedOverflowRectForPaintInvalidation(paintInvalidationContainer));
|
| + LayoutRect newBounds = newBoundsPtr ? *newBoundsPtr : computePaintInvalidationRect();
|
| + LayoutPoint newLocation = newLocationPtr ? (*newLocationPtr) : positionFromPaintInvalidationContainer(paintInvalidationContainer);
|
|
|
| // FIXME: This should use a ConvertableToTraceFormat when they are available in Blink.
|
| TRACE_EVENT2(TRACE_DISABLED_BY_DEFAULT("blink.invalidation"), "RenderObject::invalidatePaintAfterLayoutIfNeeded()",
|
| @@ -1693,9 +1693,9 @@ bool RenderObject::invalidatePaintAfterLayoutIfNeeded(const RenderLayerModelObje
|
| return false;
|
|
|
| if (invalidationReason == InvalidationIncremental) {
|
| - if (oldBounds.width() != newBounds.width() && mustRepaintBackgroundOrBorderOnWidthChange())
|
| + if (oldBounds.width() != newBounds.width() && mustInvalidateBackgroundOrBorderPaintOnWidthChange())
|
| invalidationReason = InvalidationBoundsChangeWithBackground;
|
| - else if (oldBounds.height() != newBounds.height() && mustRepaintBackgroundOrBorderOnHeightChange())
|
| + else if (oldBounds.height() != newBounds.height() && mustInvalidateBackgroundOrBorderPaintOnHeightChange())
|
| invalidationReason = InvalidationBoundsChangeWithBackground;
|
| }
|
|
|
| @@ -1750,7 +1750,7 @@ bool RenderObject::invalidatePaintAfterLayoutIfNeeded(const RenderLayerModelObje
|
|
|
| // We didn't move, but we did change size. Invalidate the delta, which will consist of possibly
|
| // two rectangles (but typically only one).
|
| - RenderStyle* outlineStyle = outlineStyleForRepaint();
|
| + RenderStyle* outlineStyle = outlineStyleForPaintInvalidation();
|
| LayoutUnit outlineWidth = outlineStyle->outlineSize();
|
| LayoutBoxExtent insetShadowExtent = style()->getBoxShadowInsetExtent();
|
| LayoutUnit width = absoluteValue(newBounds.width() - oldBounds.width());
|
| @@ -1808,32 +1808,32 @@ void RenderObject::invalidatePaintForOverflowIfNeeded()
|
| invalidatePaintForOverflow();
|
| }
|
|
|
| -bool RenderObject::checkForRepaint() const
|
| +bool RenderObject::checkForPaintInvalidation() const
|
| {
|
| return !document().view()->needsFullPaintInvalidation() && everHadLayout();
|
| }
|
|
|
| -bool RenderObject::checkForRepaintDuringLayout() const
|
| +bool RenderObject::checkForPaintInvalidationDuringLayout() const
|
| {
|
| - return !RuntimeEnabledFeatures::repaintAfterLayoutEnabled() && checkForRepaint();
|
| + return !RuntimeEnabledFeatures::repaintAfterLayoutEnabled() && checkForPaintInvalidation();
|
| }
|
|
|
| -LayoutRect RenderObject::rectWithOutlineForRepaint(const RenderLayerModelObject* repaintContainer, LayoutUnit outlineWidth) const
|
| +LayoutRect RenderObject::rectWithOutlineForPaintInvalidation(const RenderLayerModelObject* paintInvalidationContainer, LayoutUnit outlineWidth) const
|
| {
|
| - LayoutRect r(clippedOverflowRectForRepaint(repaintContainer));
|
| + LayoutRect r(clippedOverflowRectForPaintInvalidation(paintInvalidationContainer));
|
| r.inflate(outlineWidth);
|
| return r;
|
| }
|
|
|
| -LayoutRect RenderObject::clippedOverflowRectForRepaint(const RenderLayerModelObject*) const
|
| +LayoutRect RenderObject::clippedOverflowRectForPaintInvalidation(const RenderLayerModelObject*) const
|
| {
|
| ASSERT_NOT_REACHED();
|
| return LayoutRect();
|
| }
|
|
|
| -void RenderObject::mapRectToRepaintBacking(const RenderLayerModelObject* repaintContainer, LayoutRect& rect, bool fixed) const
|
| +void RenderObject::mapRectToPaintInvalidationBacking(const RenderLayerModelObject* paintInvalidationContainer, LayoutRect& rect, bool fixed) const
|
| {
|
| - if (repaintContainer == this)
|
| + if (paintInvalidationContainer == this)
|
| return;
|
|
|
| if (RenderObject* o = parent()) {
|
| @@ -1850,11 +1850,11 @@ void RenderObject::mapRectToRepaintBacking(const RenderLayerModelObject* repaint
|
| return;
|
| }
|
|
|
| - o->mapRectToRepaintBacking(repaintContainer, rect, fixed);
|
| + o->mapRectToPaintInvalidationBacking(paintInvalidationContainer, rect, fixed);
|
| }
|
| }
|
|
|
| -void RenderObject::computeFloatRectForRepaint(const RenderLayerModelObject*, FloatRect&, bool) const
|
| +void RenderObject::computeFloatRectForPaintInvalidation(const RenderLayerModelObject*, FloatRect&, bool) const
|
| {
|
| ASSERT_NOT_REACHED();
|
| }
|
| @@ -2000,7 +2000,7 @@ StyleDifference RenderObject::adjustStyleDifference(StyleDifference diff, unsign
|
| if (contextSensitiveProperties & ContextSensitivePropertyTransform && isSVG())
|
| diff.setNeedsFullLayout();
|
|
|
| - // If transform changed, and the layer does not paint into its own separate backing, then we need to repaint.
|
| + // If transform changed, and the layer does not paint into its own separate backing, then we need to invalidate paints.
|
| if (contextSensitiveProperties & ContextSensitivePropertyTransform) {
|
| // Text nodes share style with their parents but transforms don't apply to them,
|
| // hence the !isText() check.
|
| @@ -2010,7 +2010,7 @@ StyleDifference RenderObject::adjustStyleDifference(StyleDifference diff, unsign
|
| diff.setNeedsRecompositeLayer();
|
| }
|
|
|
| - // If opacity or zIndex changed, and the layer does not paint into its own separate backing, then we need to repaint (also
|
| + // If opacity or zIndex changed, and the layer does not paint into its own separate backing, then we need to invalidate paints (also
|
| // ignoring text nodes)
|
| if (contextSensitiveProperties & (ContextSensitivePropertyOpacity | ContextSensitivePropertyZIndex)) {
|
| if (!isText() && (!hasLayer() || !toRenderLayerModelObject(this)->layer()->styleDeterminedCompositingReasons()))
|
| @@ -2019,7 +2019,7 @@ StyleDifference RenderObject::adjustStyleDifference(StyleDifference diff, unsign
|
| diff.setNeedsRecompositeLayer();
|
| }
|
|
|
| - // If filter changed, and the layer does not paint into its own separate backing or it paints with filters, then we need to repaint.
|
| + // If filter changed, and the layer does not paint into its own separate backing or it paints with filters, then we need to invalidate paints.
|
| if ((contextSensitiveProperties & ContextSensitivePropertyFilter) && hasLayer()) {
|
| RenderLayer* layer = toRenderLayerModelObject(this)->layer();
|
| if (!layer->styleDeterminedCompositingReasons() || layer->paintsWithFilters())
|
| @@ -2041,7 +2041,7 @@ StyleDifference RenderObject::adjustStyleDifference(StyleDifference diff, unsign
|
| diff.setNeedsFullLayout();
|
| }
|
|
|
| - // If we have no layer(), just treat a RepaintLayer hint as a normal Repaint.
|
| + // If we have no layer(), just treat a RepaintLayer hint as a normal paint invalidation.
|
| if (diff.needsRepaintLayer() && !hasLayer()) {
|
| diff.clearNeedsRepaint();
|
| diff.setNeedsRepaintObject();
|
| @@ -2143,7 +2143,7 @@ void RenderObject::setStyle(PassRefPtr<RenderStyle> style)
|
| return;
|
|
|
| // Now that the layer (if any) has been updated, we need to adjust the diff again,
|
| - // check whether we should layout now, and decide if we need to repaint.
|
| + // check whether we should layout now, and decide if we need to invalidate paints.
|
| StyleDifference updatedDiff = adjustStyleDifference(diff, contextSensitiveProperties);
|
|
|
| if (!diff.needsFullLayout()) {
|
| @@ -2161,7 +2161,7 @@ void RenderObject::setStyle(PassRefPtr<RenderStyle> style)
|
| }
|
|
|
| if (updatedDiff.needsRepaint()) {
|
| - // Repaint with the new style, e.g., for example if we go from not having
|
| + // Invalidate paints with the new style, e.g., for example if we go from not having
|
| // an outline to having an outline.
|
| if (RuntimeEnabledFeatures::repaintAfterLayoutEnabled() && needsLayout())
|
| setShouldDoFullPaintInvalidationAfterLayout(true);
|
| @@ -2318,8 +2318,8 @@ void RenderObject::styleDidChange(StyleDifference diff, const RenderStyle* oldSt
|
| } else if (diff.needsPositionedMovementLayout())
|
| setNeedsPositionedMovementLayout();
|
|
|
| - // Don't check for repaint here; we need to wait until the layer has been
|
| - // updated by subclasses before we know if we have to repaint (in setStyle()).
|
| + // Don't check for paint invalidation here; we need to wait until the layer has been
|
| + // updated by subclasses before we know if we have to invalidate paints (in setStyle()).
|
|
|
| if (oldStyle && !areCursorsEqual(oldStyle, style())) {
|
| if (LocalFrame* frame = this->frame())
|
| @@ -2422,9 +2422,9 @@ FloatQuad RenderObject::absoluteToLocalQuad(const FloatQuad& quad, MapCoordinate
|
| return transformState.lastPlanarQuad();
|
| }
|
|
|
| -void RenderObject::mapLocalToContainer(const RenderLayerModelObject* repaintContainer, TransformState& transformState, MapCoordinatesFlags mode, bool* wasFixed) const
|
| +void RenderObject::mapLocalToContainer(const RenderLayerModelObject* paintInvalidationContainer, TransformState& transformState, MapCoordinatesFlags mode, bool* wasFixed) const
|
| {
|
| - if (repaintContainer == this)
|
| + if (paintInvalidationContainer == this)
|
| return;
|
|
|
| RenderObject* o = parent();
|
| @@ -2444,7 +2444,7 @@ void RenderObject::mapLocalToContainer(const RenderLayerModelObject* repaintCont
|
| if (o->hasOverflowClip())
|
| transformState.move(-toRenderBox(o)->scrolledContentOffset());
|
|
|
| - o->mapLocalToContainer(repaintContainer, transformState, mode, wasFixed);
|
| + o->mapLocalToContainer(paintInvalidationContainer, transformState, mode, wasFixed);
|
| }
|
|
|
| const RenderObject* RenderObject::pushMappingToContainer(const RenderLayerModelObject* ancestorToStopAt, RenderGeometryMap& geometryMap) const
|
| @@ -2504,21 +2504,21 @@ void RenderObject::getTransformFromContainer(const RenderObject* containerObject
|
| }
|
| }
|
|
|
| -FloatQuad RenderObject::localToContainerQuad(const FloatQuad& localQuad, const RenderLayerModelObject* repaintContainer, MapCoordinatesFlags mode, bool* wasFixed) const
|
| +FloatQuad RenderObject::localToContainerQuad(const FloatQuad& localQuad, const RenderLayerModelObject* paintInvalidationContainer, MapCoordinatesFlags mode, bool* wasFixed) const
|
| {
|
| // Track the point at the center of the quad's bounding box. As mapLocalToContainer() calls offsetFromContainer(),
|
| // it will use that point as the reference point to decide which column's transform to apply in multiple-column blocks.
|
| TransformState transformState(TransformState::ApplyTransformDirection, localQuad.boundingBox().center(), localQuad);
|
| - mapLocalToContainer(repaintContainer, transformState, mode | ApplyContainerFlip | UseTransforms, wasFixed);
|
| + mapLocalToContainer(paintInvalidationContainer, transformState, mode | ApplyContainerFlip | UseTransforms, wasFixed);
|
| transformState.flatten();
|
|
|
| return transformState.lastPlanarQuad();
|
| }
|
|
|
| -FloatPoint RenderObject::localToContainerPoint(const FloatPoint& localPoint, const RenderLayerModelObject* repaintContainer, MapCoordinatesFlags mode, bool* wasFixed) const
|
| +FloatPoint RenderObject::localToContainerPoint(const FloatPoint& localPoint, const RenderLayerModelObject* paintInvalidationContainer, MapCoordinatesFlags mode, bool* wasFixed) const
|
| {
|
| TransformState transformState(TransformState::ApplyTransformDirection, localPoint);
|
| - mapLocalToContainer(repaintContainer, transformState, mode | ApplyContainerFlip | UseTransforms, wasFixed);
|
| + mapLocalToContainer(paintInvalidationContainer, transformState, mode | ApplyContainerFlip | UseTransforms, wasFixed);
|
| transformState.flatten();
|
|
|
| return transformState.lastPlanarPoint();
|
| @@ -2690,10 +2690,10 @@ bool RenderObject::hasEntirelyFixedBackground() const
|
| return m_style->hasEntirelyFixedBackground();
|
| }
|
|
|
| -RenderObject* RenderObject::container(const RenderLayerModelObject* repaintContainer, bool* repaintContainerSkipped) const
|
| +RenderObject* RenderObject::container(const RenderLayerModelObject* paintInvalidationContainer, bool* paintInvalidationContainerSkipped) const
|
| {
|
| - if (repaintContainerSkipped)
|
| - *repaintContainerSkipped = false;
|
| + if (paintInvalidationContainerSkipped)
|
| + *paintInvalidationContainerSkipped = false;
|
|
|
| // This method is extremely similar to containingBlock(), but with a few notable
|
| // exceptions.
|
| @@ -2711,7 +2711,7 @@ RenderObject* RenderObject::container(const RenderLayerModelObject* repaintConta
|
|
|
| EPosition pos = m_style->position();
|
| if (pos == FixedPosition) {
|
| - return containerForFixedPosition(repaintContainer, repaintContainerSkipped);
|
| + return containerForFixedPosition(paintInvalidationContainer, paintInvalidationContainerSkipped);
|
| } else if (pos == AbsolutePosition) {
|
| // We technically just want our containing block, but
|
| // we may not have one if we're part of an uninstalled
|
| @@ -2723,8 +2723,8 @@ RenderObject* RenderObject::container(const RenderLayerModelObject* repaintConta
|
| if (o->canContainFixedPositionObjects())
|
| break;
|
|
|
| - if (repaintContainerSkipped && o == repaintContainer)
|
| - *repaintContainerSkipped = true;
|
| + if (paintInvalidationContainerSkipped && o == paintInvalidationContainer)
|
| + *paintInvalidationContainerSkipped = true;
|
|
|
| o = o->parent();
|
| }
|
| @@ -3470,7 +3470,7 @@ FloatRect RenderObject::strokeBoundingBox() const
|
|
|
| // Returns the smallest rectangle enclosing all of the painted content
|
| // respecting clipping, masking, filters, opacity, stroke-width and markers
|
| -FloatRect RenderObject::repaintRectInLocalCoordinates() const
|
| +FloatRect RenderObject::paintInvalidationRectInLocalCoordinates() const
|
| {
|
| ASSERT_NOT_REACHED();
|
| return FloatRect();
|
|
|