Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1035)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2803023005: Switch base::Value typemapping to be by value instead of by unique_ptr.

Created:
3 years, 8 months ago by Sam McNally
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews, qsr+mojo_chromium.org, tzik, posciak+watch_chromium.org, chfremer+watch_chromium.org, yzshen+watch_chromium.org, vakh+watch_chromium.org, extensions-reviews_chromium.org, Aaron Boodman, grt+watch_chromium.org, viettrungluu+watch_chromium.org, jam, abarth-chromium, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, xjz+watch_chromium.org, miu+watch_chromium.org, mlamouri+watch-content_chromium.org, nhiroki, feature-media-reviews_chromium.org, timvolodine, Lei Zhang, tfarina, tommycli, darin (slow to review), kinuko+fileapi
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch base::Value typemapping to be by value instead of by unique_ptr. base::Value is switching from pointer semantics to value semantics so mojo typemapping should match that. BUG=654988

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+181 lines, -280 lines) Patch
M chrome/browser/importer/external_process_importer_client.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/safe_media_metadata_parser.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/fileapi/safe_media_metadata_parser.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate_unittest.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/utility/extensions/extensions_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/utility/profile_import_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/utility/profile_import_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/safe_json/safe_json_parser_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M components/safe_json/safe_json_parser_impl.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M components/safe_json/utility/safe_json_parser_mojo_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/video_capture_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/video_capture_gpu_jpeg_decoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/video_capture_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/media/video_capture_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/sandboxed_unpacker.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/sandboxed_unpacker.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/utility/utility_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/base/video_frame_metadata.h View 1 chunk +1 line, -1 line 0 comments Download
M media/base/video_frame_metadata.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M media/capture/video/video_capture_device_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/common/common_custom_types_unittest.cc View 2 chunks +60 lines, -61 lines 0 comments Download
M mojo/common/values.typemap View 1 chunk +4 lines, -4 lines 0 comments Download
M mojo/common/values_struct_traits.h View 5 chunks +10 lines, -103 lines 0 comments Download
M mojo/common/values_struct_traits.cc View 1 chunk +33 lines, -39 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/struct_data_view_declaration.tmpl View 1 chunk +3 lines, -0 lines 0 comments Download
M services/preferences/persistent_pref_store_impl.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M services/preferences/pref_store_manager_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/preferences/public/cpp/persistent_pref_store_client.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M services/preferences/public/cpp/pref_registry_serializer.cc View 1 chunk +1 line, -2 lines 0 comments Download
M services/preferences/public/cpp/pref_store_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/preferences/public/cpp/pref_store_client_mixin.h View 2 chunks +2 lines, -3 lines 0 comments Download
M services/preferences/public/cpp/pref_store_client_mixin.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M services/preferences/public/cpp/pref_store_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M services/preferences/public/cpp/tests/pref_store_client_unittest.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M services/preferences/public/cpp/tracked/mock_validation_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M services/preferences/public/cpp/tracked/mock_validation_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/preferences/tracked/tracked_atomic_preference.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Issue 2791893002 Patch 60001

Messages

Total messages: 9 (9 generated)
Sam McNally
The CQ bit was checked by sammc@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-07 01:13:34 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2803023005/1
3 years, 8 months ago (2017-04-07 01:14:12 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-04-07 01:17:03 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/185961) ios-simulator-xcode-clang on ...
3 years, 8 months ago (2017-04-07 01:17:04 UTC) #4
Sam McNally
The CQ bit was checked by sammc@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-07 01:21:19 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2803023005/20001
3 years, 8 months ago (2017-04-07 01:22:11 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-04-07 04:10:18 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
3 years, 8 months ago (2017-04-07 04:10:19 UTC) #8
Sam McNally
3 years, 8 months ago (2017-04-07 05:53:08 UTC) #9 
Patchset #1 (id:1) has been deleted

Powered by Google App Engine
This is Rietveld 408576698