chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate.cc - Issue 2803023005: Switch base::Value typemapping to be by value instead of by unique_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate.cc

Issue 2803023005: Switch base::Value typemapping to be by value instead of by unique_ptr.

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate.h ('k') | chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate.cc

diff --git a/chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate.cc b/chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate.cc

index d8713517057675f93f97a66c0df08f961a298fa7..7e14fa7163461925931baec1b015878cabbd2cec 100644

--- a/chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate.cc

+++ b/chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate.cc

@@ -62,7 +62,7 @@ PreferenceValidationDelegate::~PreferenceValidationDelegate() {

void PreferenceValidationDelegate::OnAtomicPreferenceValidation(

const std::string& pref_path,

- std::unique_ptr<base::Value> value,

+ const base::Optional<base::Value>& value,

ValueState value_state,

ValueState external_validation_value_state,

bool is_personal) {