components/safe_json/safe_json_parser_impl.h - Issue 2803023005: Switch base::Value typemapping to be by value instead of by unique_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/safe_json/safe_json_parser_impl.h

Issue 2803023005: Switch base::Value typemapping to be by value instead of by unique_ptr.

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/safe_json/safe_json_parser_impl.h

diff --git a/components/safe_json/safe_json_parser_impl.h b/components/safe_json/safe_json_parser_impl.h

index 03ac99563f52e61816884f16a87dbafbdacbf77c..61edfe6999a37d9c1e87111fed6e661af6100eb0 100644

--- a/components/safe_json/safe_json_parser_impl.h

+++ b/components/safe_json/safe_json_parser_impl.h

@@ -39,7 +39,7 @@ class SafeJsonParserImpl : public SafeJsonParser {

void OnConnectionError();

// mojom::SafeJsonParser::Parse callback.

- void OnParseDone(std::unique_ptr<base::Value> result,

+ void OnParseDone(const base::Optional<base::Value>& result,

const base::Optional<std::string>& error);

// Reports the result on the calling task runner via the |success_callback_|