Pref service: Batch pref updates.

Pref service: Batch pref updates.

BUG=654988
Review-Url: https://codereview.chromium.org/2791893002
Cr-Commit-Position: refs/heads/master@{#464209}
Committed: https://chromium.googlesource.com/chromium/src/+/19860c1f69377affc0e8fae4fdece5572c8ed678

[Sam McNally, 2017-04-03 01:11:38]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-03 01:11:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-03 01:21:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-03 01:21:16]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Sam McNally, 2017-04-06 04:04:09]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 04:04:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2017-04-06 04:15:44]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 04:15:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2017-04-06 04:17:00]

Patchset #1 (id:1) has been deleted

[Sam McNally, 2017-04-06 04:17:13]

Patchset #1 (id:20001) has been deleted

[commit-bot: I haz the power, 2017-04-06 05:05:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 05:05:43]

Dry run: This issue passed the CQ dry run.

[Sam McNally, 2017-04-07 01:20:22]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 01:21:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2017-04-07 01:46:30]

Patchset #1 (id:40001) has been deleted

[commit-bot: I haz the power, 2017-04-07 02:45:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 02:45:10]

Dry run: This issue passed the CQ dry run.

[Sam McNally, 2017-04-07 03:30:52]

sammc@chromium.org changed reviewers:
+ tibell@chromium.org

[tibell, 2017-04-07 03:53:16]

lgtm

https://codereview.chromium.org/2791893002/diff/60001/services/preferences/pu...
File services/preferences/public/interfaces/preferences.mojom (right):

https://codereview.chromium.org/2791893002/diff/60001/services/preferences/pu...
services/preferences/public/interfaces/preferences.mojom:28: // Preferences have
been changed.
Preferences that have changed.

https://codereview.chromium.org/2791893002/diff/60001/services/preferences/pu...
services/preferences/public/interfaces/preferences.mojom:105: string key;
This is still a normal pref key right? It doesn't contain paths into
DictionaryValues being updated or some such?

[Sam McNally, 2017-04-07 05:24:02]

sammc@chromium.org changed reviewers:
+ mbarbella@chromium.org

[Sam McNally, 2017-04-07 05:24:03]

+mbarbella for the mojom change.

https://codereview.chromium.org/2791893002/diff/60001/services/preferences/pu...
File services/preferences/public/interfaces/preferences.mojom (right):

https://codereview.chromium.org/2791893002/diff/60001/services/preferences/pu...
services/preferences/public/interfaces/preferences.mojom:28: // Preferences have
been changed.
On 2017/04/07 03:53:16, tibell wrote:
> Preferences that have changed.

Acknowledged.

https://codereview.chromium.org/2791893002/diff/60001/services/preferences/pu...
services/preferences/public/interfaces/preferences.mojom:105: string key;
On 2017/04/07 03:53:16, tibell wrote:
> This is still a normal pref key right? It doesn't contain paths into
> DictionaryValues being updated or some such?

Correct.

[Sam McNally, 2017-04-11 23:59:35]

mbarbella: ping

[Sam McNally, 2017-04-12 02:42:48]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 02:43:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 03:28:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 03:28:29]

Dry run: This issue passed the CQ dry run.

[Martin Barbella, 2017-04-12 21:05:42]

Sorry for the delay, missed this one. LGTM.

[Sam McNally, 2017-04-12 23:34:05]

The CQ bit was checked by sammc@chromium.org

[Sam McNally, 2017-04-12 23:34:06]

The patchset sent to the CQ was uploaded after l-g-t-m from tibell@chromium.org
Link to the patchset: https://codereview.chromium.org/2791893002/#ps80001
(title: "rebase")

[commit-bot: I haz the power, 2017-04-12 23:35:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 23:48:00]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1492040045947880,
"parent_rev": "ccc903beb67d1ab6d254d0f29d99dfb0da25444d", "commit_rev":
"19860c1f69377affc0e8fae4fdece5572c8ed678"}

[commit-bot: I haz the power, 2017-04-12 23:49:16]

Description was changed from

==========
Pref service: Batch pref updates.

BUG=654988
==========

to

==========
Pref service: Batch pref updates.

BUG=654988

Review-Url: https://codereview.chromium.org/2791893002
Cr-Commit-Position: refs/heads/master@{#464209}
Committed:
https://chromium.googlesource.com/chromium/src/+/19860c1f69377affc0e8fae4fdec...
==========

[commit-bot: I haz the power, 2017-04-12 23:49:18]

Committed patchset #2 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/19860c1f69377affc0e8fae4fdec...