content/browser/renderer_host/media/video_capture_controller_unittest.cc - Issue 2803023005: Switch base::Value typemapping to be by value instead of by unique_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/media/video_capture_controller_unittest.cc

Issue 2803023005: Switch base::Value typemapping to be by value instead of by unique_ptr.

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/media/video_capture_controller.cc ('k') | content/browser/renderer_host/media/video_capture_gpu_jpeg_decoder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/media/video_capture_controller_unittest.cc

diff --git a/content/browser/renderer_host/media/video_capture_controller_unittest.cc b/content/browser/renderer_host/media/video_capture_controller_unittest.cc

index 45f164fcc59d433325ef8f8cc5f3269a12377a86..a8b8e5344e8de719823fb40e7d8f1f2dc8b314ec 100644

--- a/content/browser/renderer_host/media/video_capture_controller_unittest.cc

+++ b/content/browser/renderer_host/media/video_capture_controller_unittest.cc

@@ -88,7 +88,7 @@ class MockVideoCaptureControllerEventHandler

const media::mojom::VideoFrameInfoPtr& frame_info) override {

EXPECT_EQ(expected_pixel_format_, frame_info->pixel_format);

media::VideoFrameMetadata metadata;

- metadata.MergeInternalValuesFrom(*frame_info->metadata);

+ metadata.MergeInternalValuesFrom(frame_info->metadata);

base::TimeTicks reference_time;

EXPECT_TRUE(metadata.GetTimeTicks(media::VideoFrameMetadata::REFERENCE_TIME,

&reference_time));