Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4068)

Unified Diff: chrome/utility/profile_import_handler.cc

Issue 2803023005: Switch base::Value typemapping to be by value instead of by unique_ptr.
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/utility/profile_import_handler.h ('k') | components/safe_json/safe_json_parser_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/utility/profile_import_handler.cc
diff --git a/chrome/utility/profile_import_handler.cc b/chrome/utility/profile_import_handler.cc
index 0f6ea557c5081e28c7fbc0c3872a5c34a715edc7..e720434f44ac0f1c94c6b1ba5a4ddbd0d5bb3ba6 100644
--- a/chrome/utility/profile_import_handler.cc
+++ b/chrome/utility/profile_import_handler.cc
@@ -34,7 +34,7 @@ void ProfileImportHandler::Create(
void ProfileImportHandler::StartImport(
const importer::SourceProfile& source_profile,
uint16_t items,
- std::unique_ptr<base::DictionaryValue> localized_strings,
+ const base::DictionaryValue& localized_strings,
chrome::mojom::ProfileImportObserverPtr observer) {
content::UtilityThread::Get()->EnsureBlinkInitialized();
importer_ = importer::CreateImporterByType(source_profile.importer_type);
@@ -55,7 +55,7 @@ void ProfileImportHandler::StartImport(
ImporterCleanup();
}
bridge_ = new ExternalProcessImporterBridge(
- *localized_strings,
+ localized_strings,
ThreadSafeProfileImportObserverPtr::Create(std::move(observer)));
import_thread_->task_runner()->PostTask(
FROM_HERE, base::Bind(&Importer::StartImport, importer_,
« no previous file with comments | « chrome/utility/profile_import_handler.h ('k') | components/safe_json/safe_json_parser_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698