media/base/video_frame_metadata.h - Issue 2803023005: Switch base::Value typemapping to be by value instead of by unique_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/video_frame_metadata.h

Issue 2803023005: Switch base::Value typemapping to be by value instead of by unique_ptr.

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/base/video_frame_metadata.h

diff --git a/media/base/video_frame_metadata.h b/media/base/video_frame_metadata.h

index e83f80c4c20a26875defa2bd1618280a73420a50..d936fa6d6c8a97beb7a8794300c3013b491e68bc 100644

--- a/media/base/video_frame_metadata.h

+++ b/media/base/video_frame_metadata.h

@@ -156,7 +156,7 @@ class MEDIA_EXPORT VideoFrameMetadata {

bool IsTrue(Key key) const WARN_UNUSED_RESULT;

// For serialization.

- std::unique_ptr<base::DictionaryValue> CopyInternalValues() const;

+ const base::DictionaryValue& GetInternalValues() const;

void MergeInternalValuesFrom(const base::DictionaryValue& in);

// Merges internal values from |metadata_source|.

« no previous file with comments | « extensions/utility/utility_handler.cc ('k') | media/base/video_frame_metadata.cc » ('j') | no next file with comments »