Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3246)

Unified Diff: extensions/browser/sandboxed_unpacker.cc

Issue 2803023005: Switch base::Value typemapping to be by value instead of by unique_ptr.
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/sandboxed_unpacker.h ('k') | extensions/utility/utility_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/sandboxed_unpacker.cc
diff --git a/extensions/browser/sandboxed_unpacker.cc b/extensions/browser/sandboxed_unpacker.cc
index 730ac6b1d018f55ad7c3c14ddb7da59d72499427..44d19a5fdba117f044140e793a97e30bd5e96f38 100644
--- a/extensions/browser/sandboxed_unpacker.cc
+++ b/extensions/browser/sandboxed_unpacker.cc
@@ -426,7 +426,7 @@ void SandboxedUnpacker::Unpack(const base::FilePath& directory) {
void SandboxedUnpacker::UnpackDone(
const base::string16& error,
- std::unique_ptr<base::DictionaryValue> manifest) {
+ const base::Optional<base::DictionaryValue>& manifest) {
DCHECK_CURRENTLY_ON(BrowserThread::IO);
utility_process_mojo_client_.reset();
@@ -440,7 +440,7 @@ void SandboxedUnpacker::UnpackDone(
unpacker_io_task_runner_->PostTask(
FROM_HERE, base::Bind(&SandboxedUnpacker::UnpackExtensionSucceeded, this,
- base::Passed(&manifest)));
+ base::Passed(manifest->CreateDeepCopy())));
}
void SandboxedUnpacker::UnpackExtensionSucceeded(
« no previous file with comments | « extensions/browser/sandboxed_unpacker.h ('k') | extensions/utility/utility_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698