Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Side by Side Diff: services/preferences/public/cpp/tracked/mock_validation_delegate.h

Issue 2803023005: Switch base::Value typemapping to be by value instead of by unique_ptr.
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef SERVICES_PREFERENCES_PUBLIC_CPP_TRACKED_MOCK_VALIDATION_DELEGATE_H_ 5 #ifndef SERVICES_PREFERENCES_PUBLIC_CPP_TRACKED_MOCK_VALIDATION_DELEGATE_H_
6 #define SERVICES_PREFERENCES_PUBLIC_CPP_TRACKED_MOCK_VALIDATION_DELEGATE_H_ 6 #define SERVICES_PREFERENCES_PUBLIC_CPP_TRACKED_MOCK_VALIDATION_DELEGATE_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 9
10 #include <string> 10 #include <string>
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
85 class MockValidationDelegate 85 class MockValidationDelegate
86 : public prefs::mojom::TrackedPreferenceValidationDelegate { 86 : public prefs::mojom::TrackedPreferenceValidationDelegate {
87 public: 87 public:
88 explicit MockValidationDelegate( 88 explicit MockValidationDelegate(
89 scoped_refptr<MockValidationDelegateRecord> record); 89 scoped_refptr<MockValidationDelegateRecord> record);
90 ~MockValidationDelegate() override; 90 ~MockValidationDelegate() override;
91 91
92 // TrackedPreferenceValidationDelegate implementation. 92 // TrackedPreferenceValidationDelegate implementation.
93 void OnAtomicPreferenceValidation( 93 void OnAtomicPreferenceValidation(
94 const std::string& pref_path, 94 const std::string& pref_path,
95 std::unique_ptr<base::Value> value, 95 const base::Optional<base::Value>& value,
96 prefs::mojom::TrackedPreferenceValidationDelegate::ValueState value_state, 96 prefs::mojom::TrackedPreferenceValidationDelegate::ValueState value_state,
97 prefs::mojom::TrackedPreferenceValidationDelegate::ValueState 97 prefs::mojom::TrackedPreferenceValidationDelegate::ValueState
98 external_validation_value_state, 98 external_validation_value_state,
99 bool is_personal) override; 99 bool is_personal) override;
100 void OnSplitPreferenceValidation( 100 void OnSplitPreferenceValidation(
101 const std::string& pref_path, 101 const std::string& pref_path,
102 const std::vector<std::string>& invalid_keys, 102 const std::vector<std::string>& invalid_keys,
103 const std::vector<std::string>& external_validation_invalid_keys, 103 const std::vector<std::string>& external_validation_invalid_keys,
104 prefs::mojom::TrackedPreferenceValidationDelegate::ValueState value_state, 104 prefs::mojom::TrackedPreferenceValidationDelegate::ValueState value_state,
105 prefs::mojom::TrackedPreferenceValidationDelegate::ValueState 105 prefs::mojom::TrackedPreferenceValidationDelegate::ValueState
106 external_validation_value_state, 106 external_validation_value_state,
107 bool is_personal) override; 107 bool is_personal) override;
108 108
109 private: 109 private:
110 // Adds a new validation event. 110 // Adds a new validation event.
111 void RecordValidation( 111 void RecordValidation(
112 const std::string& pref_path, 112 const std::string& pref_path,
113 prefs::mojom::TrackedPreferenceValidationDelegate::ValueState value_state, 113 prefs::mojom::TrackedPreferenceValidationDelegate::ValueState value_state,
114 prefs::mojom::TrackedPreferenceValidationDelegate::ValueState 114 prefs::mojom::TrackedPreferenceValidationDelegate::ValueState
115 external_validation_value_state, 115 external_validation_value_state,
116 bool is_personal, 116 bool is_personal,
117 prefs::mojom::TrackedPreferenceMetadata::PrefTrackingStrategy strategy); 117 prefs::mojom::TrackedPreferenceMetadata::PrefTrackingStrategy strategy);
118 118
119 scoped_refptr<MockValidationDelegateRecord> record_; 119 scoped_refptr<MockValidationDelegateRecord> record_;
120 120
121 DISALLOW_COPY_AND_ASSIGN(MockValidationDelegate); 121 DISALLOW_COPY_AND_ASSIGN(MockValidationDelegate);
122 }; 122 };
123 123
124 #endif // SERVICES_PREFERENCES_PUBLIC_CPP_TRACKED_MOCK_VALIDATION_DELEGATE_H_ 124 #endif // SERVICES_PREFERENCES_PUBLIC_CPP_TRACKED_MOCK_VALIDATION_DELEGATE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698