Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Unified Diff: extensions/utility/utility_handler.cc

Issue 2803023005: Switch base::Value typemapping to be by value instead of by unique_ptr.
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/sandboxed_unpacker.cc ('k') | media/base/video_frame_metadata.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/utility/utility_handler.cc
diff --git a/extensions/utility/utility_handler.cc b/extensions/utility/utility_handler.cc
index 4b8e4ac3c7fcbb45b29e93ed737c78a054f766d3..0e85593a4deb73fa59483aa4a74be80dbeae3c5b 100644
--- a/extensions/utility/utility_handler.cc
+++ b/extensions/utility/utility_handler.cc
@@ -63,9 +63,9 @@ class ExtensionUnpackerImpl : public extensions::mojom::ExtensionUnpacker {
Unpacker unpacker(path.DirName(), path, extension_id, location,
creation_flags);
if (unpacker.Run()) {
- callback.Run(base::string16(), unpacker.TakeParsedManifest());
+ callback.Run(base::string16(), std::move(*unpacker.TakeParsedManifest()));
} else {
- callback.Run(unpacker.error_message(), nullptr);
+ callback.Run(unpacker.error_message(), base::nullopt);
}
}
« no previous file with comments | « extensions/browser/sandboxed_unpacker.cc ('k') | media/base/video_frame_metadata.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698