Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: media/base/video_frame_metadata.cc

Issue 2803023005: Switch base::Value typemapping to be by value instead of by unique_ptr.
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/video_frame_metadata.h ('k') | media/capture/video/video_capture_device_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/video_frame_metadata.cc
diff --git a/media/base/video_frame_metadata.cc b/media/base/video_frame_metadata.cc
index 0ce0b2cdc588c01c20a596f772711c2053a8ed40..58ce920553cfac133db44eced90a3136e4104c0c 100644
--- a/media/base/video_frame_metadata.cc
+++ b/media/base/video_frame_metadata.cc
@@ -151,9 +151,8 @@ bool VideoFrameMetadata::IsTrue(Key key) const {
return GetBoolean(key, &value) && value;
}
-std::unique_ptr<base::DictionaryValue> VideoFrameMetadata::CopyInternalValues()
- const {
- return dictionary_.CreateDeepCopy();
+const base::DictionaryValue& VideoFrameMetadata::GetInternalValues() const {
+ return dictionary_;
}
void VideoFrameMetadata::MergeInternalValuesFrom(
« no previous file with comments | « media/base/video_frame_metadata.h ('k') | media/capture/video/video_capture_device_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698