Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Side by Side Diff: chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate.h

Issue 2803023005: Switch base::Value typemapping to be by value instead of by unique_ptr.
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_SAFE_BROWSING_INCIDENT_REPORTING_PREFERENCE_VALIDATION_DE LEGATE_H_ 5 #ifndef CHROME_BROWSER_SAFE_BROWSING_INCIDENT_REPORTING_PREFERENCE_VALIDATION_DE LEGATE_H_
6 #define CHROME_BROWSER_SAFE_BROWSING_INCIDENT_REPORTING_PREFERENCE_VALIDATION_DE LEGATE_H_ 6 #define CHROME_BROWSER_SAFE_BROWSING_INCIDENT_REPORTING_PREFERENCE_VALIDATION_DE LEGATE_H_
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
(...skipping 14 matching lines...) Expand all
25 public: 25 public:
26 PreferenceValidationDelegate( 26 PreferenceValidationDelegate(
27 Profile* profile, 27 Profile* profile,
28 std::unique_ptr<IncidentReceiver> incident_receiver); 28 std::unique_ptr<IncidentReceiver> incident_receiver);
29 ~PreferenceValidationDelegate() override; 29 ~PreferenceValidationDelegate() override;
30 30
31 private: 31 private:
32 // TrackedPreferenceValidationDelegate methods. 32 // TrackedPreferenceValidationDelegate methods.
33 void OnAtomicPreferenceValidation( 33 void OnAtomicPreferenceValidation(
34 const std::string& pref_path, 34 const std::string& pref_path,
35 std::unique_ptr<base::Value> value, 35 const base::Optional<base::Value>& value,
36 prefs::mojom::TrackedPreferenceValidationDelegate::ValueState value_state, 36 prefs::mojom::TrackedPreferenceValidationDelegate::ValueState value_state,
37 prefs::mojom::TrackedPreferenceValidationDelegate::ValueState 37 prefs::mojom::TrackedPreferenceValidationDelegate::ValueState
38 external_validation_value_state, 38 external_validation_value_state,
39 bool is_personal) override; 39 bool is_personal) override;
40 void OnSplitPreferenceValidation( 40 void OnSplitPreferenceValidation(
41 const std::string& pref_path, 41 const std::string& pref_path,
42 const std::vector<std::string>& invalid_keys, 42 const std::vector<std::string>& invalid_keys,
43 const std::vector<std::string>& external_validation_invalid_keys, 43 const std::vector<std::string>& external_validation_invalid_keys,
44 prefs::mojom::TrackedPreferenceValidationDelegate::ValueState value_state, 44 prefs::mojom::TrackedPreferenceValidationDelegate::ValueState value_state,
45 prefs::mojom::TrackedPreferenceValidationDelegate::ValueState 45 prefs::mojom::TrackedPreferenceValidationDelegate::ValueState
46 external_validation_value_state, 46 external_validation_value_state,
47 bool is_personal) override; 47 bool is_personal) override;
48 48
49 Profile* profile_; 49 Profile* profile_;
50 std::unique_ptr<IncidentReceiver> incident_receiver_; 50 std::unique_ptr<IncidentReceiver> incident_receiver_;
51 51
52 DISALLOW_COPY_AND_ASSIGN(PreferenceValidationDelegate); 52 DISALLOW_COPY_AND_ASSIGN(PreferenceValidationDelegate);
53 }; 53 };
54 54
55 } // namespace safe_browsing 55 } // namespace safe_browsing
56 56
57 #endif // CHROME_BROWSER_SAFE_BROWSING_INCIDENT_REPORTING_PREFERENCE_VALIDATION _DELEGATE_H_ 57 #endif // CHROME_BROWSER_SAFE_BROWSING_INCIDENT_REPORTING_PREFERENCE_VALIDATION _DELEGATE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698